[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor updated this revision to Diff 324551. teemperor added a comment. - Also clarify error message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96939/new/ https://reviews.llvm.org/D96939 Files: lldb/source/Commands/CommandObjectTarget.cpp Index: lldb/source/Commands/CommandO

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

jasonmolenda added a comment. In D96939#2570834 , @teemperor wrote: > In D96939#2570831 , @jasonmolenda > wrote: > >> In D96939#2570830 , @teemperor >> wrote: >> >>> What a

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor added a comment. In D96939#2570831 , @jasonmolenda wrote: > In D96939#2570830 , @teemperor wrote: > >> What about: >> >> error: Couldn't recognise core file format of . >> note: If the file is a core

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

jasonmolenda added a comment. In D96939#2570830 , @teemperor wrote: > What about: > > error: Couldn't recognise core file format of . > note: If the file is a core file in a compressed file archive, it first > needs to be manually extracted before it

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor added a comment. In D96939#2570810 , @jasonmolenda wrote: > I mean, I'm also fine with suggesting that the file might be compressed, > because this is a REAL common source of an unrecognized core file format. > But also we can more clearly sa

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

jasonmolenda added a comment. I mean, I'm also fine with suggesting that the file might be compressed, because this is a REAL common source of an unrecognized core file format. But also we can more clearly say "Doesn't look like a core file to me" and also noting that compression is something

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:431 + result.AppendMessage( + "Note: If the passed file is a compressed file archive containing" + " a core file, you first need to manually extract th

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

jasonmolenda added a comment. Thanks for taking time to deal with this annoying error message. Should we just remove the "Unable to find process plug-in for core file" text altogether? It means nothing unless you work on lldb and understand the plugin system. "Unrecognized core file format"

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:431 + result.AppendMessage( + "Note: If the passed file is a compressed file archive containing" + " a core file, you first need to manually extract the c

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor updated this revision to Diff 324546. teemperor added a comment. - Made `note:` lower case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96939/new/ https://reviews.llvm.org/D96939 Files: lldb/source/Commands/CommandObjectTarget.cpp Index: lldb/source/Commands/CommandObjec

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:431 + result.AppendMessage( + "Note: If the passed file is a compressed file archive containing" + " a core file, you first need to manually extract th

[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Core files are frequently compressed in some compressed archive and users aren't aware that LLDB can't extract