This revision was automatically updated to reflect the committed changes.
Closed by commit rGd77e3c6aec29: [lldb][NFC] Don't inherit from UserID in
ValueObject (authored by teemperor).
Herald added a subscriber: lldb-commits.
Changed prior to commit:
https://reviews.llvm.org/D97205?vs=325708&id
teemperor updated this revision to Diff 325708.
teemperor added a comment.
- Rebased.
- Add a `GetID()` call where we relied on the `==` overload before.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97205/new/
https://reviews.llvm.org/D97205
Files:
lldb/include/lldb/Core/ValueObject
shafik added inline comments.
Comment at: lldb/include/lldb/Core/ValueObject.h:888
+ /// Unique identifier for every value object.
+ UserID m_id;
+
This makes more sense, `ValueObject` is not a `UserID` but contains one.
CHANGES SINCE LAST ACTION
https://re
teemperor created this revision.
teemperor added a reviewer: LLDB.
teemperor added a project: LLDB.
Herald added a subscriber: JDevlieghere.
teemperor requested review of this revision.
ValueObject inherits from UserID which is just a bad idea:
- The inheritance gives ValueObject some member func
