This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
JDevlieghere marked an inline comment as done.
Closed by commit rG38dfb235db19: [lldb] Support debugging utility functions
(authored by JDevlieghere).
Herald added a pr
jingham added a comment.
I am pretty sure other Unix-es share the code to dlopen images that backs
"Process::LoadImage". It is trivial compared to the ObjC ones, but is does
have a couple of lines of code, 'cause it tries the dlopen and then if that
fails, calls dlerror to fetch the error. Th
teemperor accepted this revision.
teemperor added a comment.
Some small nitpicks about comments, otherwise LGTM
I was kinda thinking how we could test this, but all our utility functions are
anyway only on macOS and very Obj-C runtime related, so that sounds like a pain
to do right...
(PS: Als
JDevlieghere updated this revision to Diff 325837.
JDevlieghere marked 6 inline comments as done.
JDevlieghere added a comment.
Address code review feedback
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97249/new/
https://reviews.llvm.org/D97249
Files:
lldb/include/lldb/Expression/Ut
teemperor added inline comments.
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:38
const char *ClangExpressionSourceCode::g_expression_prefix =
-"#line 1 \"" PREFIX_NAME R"("
+"#line 1 \"" PREFIX_NAME R"("#line 1
#ifndef offsetof
-
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: lldb/source/Expression/FunctionCaller.cpp:324
EvaluateExpressionOptions real_options = options;
real_options.SetDebug(false);
+ real_options.SetGenerateDebugInfo(debug);
shafik added inline comments.
Comment at: lldb/source/Expression/FunctionCaller.cpp:324
EvaluateExpressionOptions real_options = options;
real_options.SetDebug(false);
+ real_options.SetGenerateDebugInfo(debug);
It feels a little weird you are using the na
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This will be really handy! The code for UserExpressions ends up doing this
same thing (over in ClangExpressionParser::ParseInternal. But given how
light-weight creating the file is I'm pre
JDevlieghere created this revision.
JDevlieghere added a reviewer: jingham.
Herald added a subscriber: pengfei.
JDevlieghere requested review of this revision.
LLDB uses utility functions to run code in the inferior for its own internal
purposes, such as reading classes from the Objective-C runti
