[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

2021-03-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 333064. mgorny retitled this revision from "[lldb] [Process/Linux] Watch for fork notifications" to "[lldb] [Process/Linux] Watch for fork/vfork notifications". mgorny edited the summary of this revision. mgorny added a comment. Included `vfork()`. Still have

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

2021-03-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 333122. mgorny added a comment. Handle `clone(2)` for new process as well (and add a test for it). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

2021-03-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 333124. mgorny added a comment. Also add clone+watchpoint test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/include/lldb/Host/linux/Ho

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

2021-03-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/test/Shell/Subprocess/fork-follow-parent.test:6 +process launch +# CHECK: function run in child +# CHECK-NOT: function run in parent The tests sometimes fail if child starts after the breakpoint is hit (and therefor

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

2021-03-25 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:145 + // Remove all software breakpoints and return a vector of breakpoint data + // that can be used to readd them. Long term, these functions are probably unnece

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

2021-03-25 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:145 + // Remove all software breakpoints and return a vector of breakpoint data + // that can be used to readd them. mgorny wrote: > Long term, these functions are

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

2021-03-25 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 333254. mgorny added a comment. Move saved breakpoint list directly into `NativeProcessProtocol`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h