[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

JDevlieghere added a comment. In D98842#2638929 , @stella.stamenova wrote: > This did end up breaking the windows build bot... > > https://lab.llvm.org/buildbot/#/builders/83/builds/4808 Thanks, the error message suggests the tests are run twice and the

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova added a comment. This did end up breaking the windows build bot... https://lab.llvm.org/buildbot/#/builders/83/builds/4808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 _

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c52d4fd4c24: [lldb] Make the API, Shell and Unit tests independent lit test suites (authored by JDevlieghere). Herald added a project: LLDB. Change

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Clean builds for all the test targets work now and this also looks good, so let's ship it. (also thanks for working on that, the unit test builds where a big annoyance when testing API

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

JDevlieghere updated this revision to Diff 331918. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 Files: lldb/test/API/CMakeLists.txt lldb/test/CMakeLists.txt lldb/test/Shell/CMakeLists.txt lldb/test

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

JDevlieghere updated this revision to Diff 331630. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 Files: lldb/test/API/CMakeLists.txt lldb/test/CMakeLists.txt lldb/test/Shell/CMakeLists.txt lldb/test/Unit/CMakeLists.txt lldb/unittests/C

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

JDevlieghere updated this revision to Diff 331627. JDevlieghere added a comment. Add `EXCLUDE_FROM_CHECK_ALL` to the new targets to avoid tests getting added twice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 Files: lldb/test/API/CMakeLis

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova added a comment. In D98842#2634902 , @teemperor wrote: > Just gonna post a comment to point out that this apparently adds all tests > twice to `check-all` which makes the tests go kaputt (but I only messaged > Jonas directly about that,

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Just gonna post a comment to point out that this apparently adds all tests twice to `check-all` which makes the tests go kaputt (but I only messaged Jonas directly about that,

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Looks good as long as it doesn't break windows :O CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 ___

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, stella.stamenova, kastiglione. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Make the api, shell and unit tests independent lit test suites. This allows us to specify differen