[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/Process.h:79 void SetExtraStartupCommands(const Args ); + uint64_t GetPointerAuthenticationAddressMask() const; + void SetPointerAuthenticationAddressMask(const uint64_t mask); pcc wrote:

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

pcc added inline comments. Comment at: lldb/include/lldb/Target/Process.h:79 void SetExtraStartupCommands(const Args ); + uint64_t GetPointerAuthenticationAddressMask() const; + void SetPointerAuthenticationAddressMask(const uint64_t mask); omjavaid wrote:

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/Process.h:79 void SetExtraStartupCommands(const Args ); + uint64_t GetPointerAuthenticationAddressMask() const; + void SetPointerAuthenticationAddressMask(const uint64_t mask); This

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

justincohen marked 2 inline comments as done. justincohen added inline comments. Comment at: lldb/source/Plugins/Process/minidump/MinidumpTypes.h:113 + +struct CrashpadInfo { + llvm::support::ulittle32_t version; markmentovai wrote: > Ensure alignment is

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

justincohen updated this revision to Diff 333608. justincohen added a comment. Check CrashpadInfo version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98886/new/ https://reviews.llvm.org/D98886 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

justincohen updated this revision to Diff 333601. justincohen added a comment. Inverted mask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98886/new/ https://reviews.llvm.org/D98886 Files: lldb/include/lldb/Target/Process.h