[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

2021-03-29 Thread Alexey Vasilyev via Phabricator via lldb-commits
vasilyev abandoned this revision. vasilyev added a comment. Resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99331/new/ https://reviews.llvm.org/D99331 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

2021-03-29 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. So from what I understand this is resolved? If yes, can you abandon/close this revision (You can do this by selecting the "Abandon revision" action above the input field where you can comment). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

2021-03-29 Thread Alexey Vasilyev via Phabricator via lldb-commits
vasilyev added a comment. Thanks for the comments! You are right, this is indeed fixed by https://github.com/llvm/llvm-project/commit/352f16db87f583ec7f55f8028647b5fd8616111f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99331/new/ https://reviews

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

2021-03-25 Thread Jim Ingham via Phabricator via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Raphael is right. The default values of the target.process.thread.step-avoid-regexp are set such that if lldb finds itself in a function inlined from std:: it will automatically s

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

2021-03-25 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor edited reviewers, added: jingham; removed: LLVM. teemperor added a comment. Thanks for the patch! A few general notes: - You probably want to upload the diffs with more context (`git diff -U` or something like that) to get rid of the "Context not available" in the source changes

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

2021-03-25 Thread Alexey Vasilyev via Phabricator via lldb-commits
vasilyev created this revision. vasilyev added a reviewer: LLVM. vasilyev added projects: LLVM, LLDB test suite on simulator. vasilyev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The tests expect the debugger steps into the function, no