[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb601c6719226: [lldb] [client] Support for multiprocess extension (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yea, I think it should be fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603 ___ lldb-commits

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny added a comment. @labath, any further comments or is this good to go then? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny updated this revision to Diff 336052. mgorny added a comment. Removed the hanging test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

labath added a comment. Yeah, that's tricky. For a inconsistent/unsupported response like this, probably the only reasonable thing we can do print some error message, terminate the connection and put the inferior into some terminal state. However, I don't think we have anything like that (and

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny updated this revision to Diff 334930. mgorny added a comment. Added a `skip` to the hanging new test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny updated this revision to Diff 334725. mgorny added a comment. Add some tests. @labath, I'd use some help now. When the stop reason includes wrong PID, the GDB exchange seems to enter a dead loop: b-remote.async> < 5> send packet: $c#63 b-remote.async> < 25> read packet:

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny updated this revision to Diff 334686. mgorny marked an inline comment as done. mgorny added a comment. Changed `GetCurrentProcessAndThreadIDs()` to return the vector, and reformatted. Tests next. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

labath added a comment. I think this looks fine. Could you also create a gdb-client test case (you can ignore the default thread thingy)? Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1131 bool

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny updated this revision to Diff 334404. mgorny added a comment. Added better PID mismatch handling in `SetThreadStopInfo()`. Not that most of the call sites actually check the return value... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny added a comment. @labath, split `GetCurrentThreadIDs()` as suggested. I've also modified `GetCurrentProcessID()` to prefer explicit PID over TID when available. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99603/new/ https://reviews.llvm.org/D99603

[Lldb-commits] [PATCH] D99603: [lldb] [client] Support for multiprocess extension

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Add a minimal support for the multiprocess extension in gdb-remote client. It accepts PIDs as part of thread-ids, and rejects PIDs that do not match the current inferior.