Michael137 wrote:
I'm going to revert this for now until since the bots have been red for a while
now
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere wrote:
`LLDB_CURSES_LIBS` is scoped to lldbCore, which the EditLine unit test isn't
linking. If its also necessary in Host, then we should hoist it up and link
both libraries against it.
Anyway, that also means my initial assessment was wrong. I looked for the
header include but
jimingham wrote:
This patch has been causing the Darwin bots on GreenDragon to fail consistently
since it was submitted.
The problem is that the lldb/unitest/EditLine needs setupterm which comes from
libcurses.dylib. However that was finding its way into this build line for
this test, it's
mysterymath wrote:
I did some brief investigation on our end. The pkg-config file for libedit
includes a private dependency on libncurses, which provides the terminfo
functions. The issue here seems to be one uncovered in LLVM's
FindLibEdit.cmake. We're building against a static libedit, but
gulfemsavrun wrote:
Ok, thanks for your analysis @aaronmondal!
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aaronmondal wrote:
@gulfemsavrun The file `terminal.c` that is causing this linker error is not in
LLVM but in `libedit`. The configure step doesn't find `libedit`:
```
Not searching for unused variables given on the command line.
-- Could NOT find LibEdit (missing: LibEdit_INCLUDE_DIRS
gulfemsavrun wrote:
We started seeing the following issue after this patch in our Clang toolchain
builders:
```
1448/1517](45) Linking CXX executable unittests/LineEditor/LineEditorTests
FAILED: unittests/LineEditor/LineEditorTests
: && /b/s/w/ir/x/w/cipd/bin/clang++
https://github.com/aaronmondal closed
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aaronmondal updated
https://github.com/llvm/llvm-project/pull/92865
>From 124be680ca3ae82edd6fa9a49b1fd171d1babbf5 Mon Sep 17 00:00:00 2001
From: Aaron Siddhartha Mondal
Date: Tue, 21 May 2024 06:37:49 +0200
Subject: [PATCH] [Support] Remove terminfo dependency
The terminfo
JDevlieghere wrote:
No objections in the context of LLDB. We don't use terminfo directly (although
I think editline does, but that isn't affected by this) and if we want the TUI
we depend on curses anyway.
https://github.com/llvm/llvm-project/pull/92865
keith wrote:
looks like the .bazelrc still has mentions of this
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-clang
Author: Aaron Siddhartha Mondal (aaronmondal)
Changes
The terminfo dependency introduces a significant nonhermeticity into the build.
It doesn't respect `--no-undefined-version` meaning that it's not a dependency
that
https://github.com/aaronmondal created
https://github.com/llvm/llvm-project/pull/92865
The terminfo dependency introduces a significant nonhermeticity into the build.
It doesn't respect `--no-undefined-version` meaning that it's not a dependency
that can be built with Clang 17+. This forces
15 matches
Mail list logo
