https://github.com/labath closed https://github.com/llvm/llvm-project/pull/95959
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/95959
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/95959
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 01/14] [API] add GetSyntheticValue
---
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 01/12] [API] add GetSyntheticValue
---
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 01/11] [API] add GetSyntheticValue
---
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5da7179cb3ff80203f58ddea71562816b2ae4ff6
bcfebfbcbc4196daa9ab03874a58b53d44afeb3c --
v-bulle wrote:
> The one thing about this that strikes me as odd is that if you have an
> SBValue that doesn't have a Synthetic Value, this will return the
> non-synthetic value. The GetNonSyntheticValue didn't have this problem
> because there's always a non-synthetic value, so provided the
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 01/10] [API] add GetSyntheticValue
---
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 1/4] [API] add GetSyntheticValue
---
labath wrote:
> Would it make more sense to make the ValueImpl that's going to represent the
> synthetic value then check whether that really is synthetic, and return an
> empty SBValue if it is not?
Sounds like a good idea to me.
https://github.com/llvm/llvm-project/pull/95959
jimingham wrote:
The one thing about this that strikes me as odd is that if you have an SBValue
that doesn't have a Synthetic Value, this will return the non-synthetic value.
Getting the NonSynthetic Value didn't have this problem because there's always
a non-synthetic value, so provided the
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 1/4] [API] add GetSyntheticValue
---
@@ -155,6 +155,18 @@ def cleanup():
],
)
labath wrote:
You have two categories, but they both have a summary provider for the same
type (`CCC`). (Enabling one category does not automatically disable the other
ones.) Right now, lldb seems
@@ -155,6 +155,18 @@ def cleanup():
],
)
v-bulle wrote:
I don't think we can have a conflict. In this test we have several categories
which are enabled one after the other. I just add a new one (with a new name
CCCSynth2).
https://github.com/labath approved this pull request.
Thanks.
https://github.com/llvm/llvm-project/pull/95959
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -155,6 +155,18 @@ def cleanup():
],
)
labath wrote:
```suggestion
)
self.dbg.GetCategory("CCCSynth").SetEnabled(False)
```
I'm not sure how lldb chooses the summary providers in case of conflicts, but
since that's not
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/95959
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 1/3] [API] add GetSyntheticValue
---
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
d8091522664248a4ba73d8d1e7fa6ac57bfcf67c...e0ed752849486f67d9fddbef3767a1756afd1ab2
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH 1/2] [API] add GetSyntheticValue
---
https://github.com/v-bulle updated
https://github.com/llvm/llvm-project/pull/95959
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject: [PATCH] [API] add GetSyntheticValue
---
labath wrote:
We should also add a test case for the new API. You can just take an existing
test case with some synthetic values (e.g. `TestFormattersSBAPI.py`), add some
Get(Non)SyntheticValue calls, and make sure they do what they should.
https://github.com/llvm/llvm-project/pull/95959
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vincent Belliard (v-bulle)
Changes
Adds GetSyntheticValue to the API on top of GetNonSyntheticValue.
---
Full diff: https://github.com/llvm/llvm-project/pull/95959.diff
2 Files Affected:
- (modified) lldb/include/lldb/API/SBValue.h (+2)
https://github.com/v-bulle created
https://github.com/llvm/llvm-project/pull/95959
Adds GetSyntheticValue to the API on top of GetNonSyntheticValue.
>From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001
From: Vincent Belliard
Date: Wed, 12 Jun 2024 14:23:15 -0700
Subject:
25 matches
Mail list logo
