[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

2024-06-07 Thread Shivam Gupta via lldb-commits
xgupta wrote: > The change LGTM, but I have a few suggestions regarding the title and > description: > > * Retitle the PR to something like "[lldb] Remove dead code block (NFC)" > or something that conveys the intent/outcome. The modified file and line > number are already part of the com

[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

2024-06-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The change LGTM, but I have a few suggestions regarding the title and description: - Retitle the PR to something like "[lldb] Remove dead code block (NFC)" or something that conveys the intent/outcome. The modified file and line number are already part of the commit and a

[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

2024-06-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes Fixes #85985 lldb/source/Utility/Scalar.cpp:756:23: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition] --- Full diff: https://github.com/llvm/llvm-project/pull/94775.d

[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

2024-06-07 Thread Shivam Gupta via lldb-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/94775 Fixes #85985 lldb/source/Utility/Scalar.cpp:756:23: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition] >From da77334ac60233e688812e39480f58bbe1a251eb Mon Sep 17 00:00:00