https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
LGTM
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
The warnings look good to me, thanks for taking care of that.
How does this look @jimingham?
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68013
>From a472a16e6032ce0cef0acae6957f690f7e6cc4a3 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 13:56:00 -0400
Subject: [PATCH] [LLDB] Allow specifying a custom exports file
LLDB
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68013
>From d557ea59b9c24387244280566260c33ac6bb9367 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 13:56:00 -0400
Subject: [PATCH] [LLDB] Allow specifying a custom exports file
LLDB
walter-erquinigo wrote:
I'll add the warning as you guys mention. That'll set clear expectations on
what users will be getting.
Besides that, @bulbazord , the current symbols getting exported by
`third-party/llvm-project/lldb/source/API/liblldb-private.exports` are not all
the symbols, but
jimingham wrote:
That sounds appropriate to me.
Jim
> On Oct 4, 2023, at 3:03 PM, Alex Langford ***@***.***> wrote:
>
>
> I think we need to make it clear wherever in the build system that the knob
> for turning on these exports lives that you use these symbols at your own
> risk, and we
bulbazord wrote:
> I think we need to make it clear wherever in the build system that the knob
> for turning on these exports lives that you use these symbols at your own
> risk, and we guarantee NO ABI stability for anything but the SB API's. We
> know that on this list but somebody getting
jimingham wrote:
I think we need to make it clear wherever in the build system that the knob for
turning on these exports lives that you use these symbols at your own risk, and
we guarantee NO ABI stability for anything but the SB API's. We know that on
this list but somebody getting the
bulbazord wrote:
Personally I have no qualms about this. It's just an option that lets you
choose which symbols to export. We already allow exporting every symbol, why
not just some of them? I would be careful though, since we don't guarantee any
stability for lldb_private (including things
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` that exports the lldb,
lldb_private namespaces, as well as other symbols like python and lua (see
`third-party/llvm-project/lldb/source/API/liblldb-private.exports`). However,
not all
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/68013
LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` that exports the lldb,
lldb_private namespaces, as well as other symbols like python and lua (see
15 matches
Mail list logo
