https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hokein wrote:
Thanks for the review.
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/71928
>From 08c3b1a40b508d360f47bed6d7d42050c18b01a0 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH 1/5] [LLDB] Display artificial __promise and __coro_frame
variables.
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM (once bots are happy)
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type):
],
)
-# Run until after the `co_yield`
process = self.process()
+
+# Break at a coroutine body
+lldbutil.continue_to_source_breakpoint(
+ self, process, "//
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/71928
>From 08c3b1a40b508d360f47bed6d7d42050c18b01a0 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH 1/4] [LLDB] Display artificial __promise and __coro_frame
variables.
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type):
],
)
-# Run until after the `co_yield`
process = self.process()
+
+# Break at a coroutine body
+lldbutil.continue_to_source_breakpoint(
+ self, process, "//
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hokein commented:
Thanks for the comments.
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type):
],
)
-# Run until after the `co_yield`
process = self.process()
+
+# Break at a coroutine body
+lldbutil.continue_to_source_breakpoint(
+ self, process, "//
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ return name == g_this ||
+ // Artificial coroutine-related vari
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/71928
>From 08c3b1a40b508d360f47bed6d7d42050c18b01a0 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH 1/3] [LLDB] Display artificial __promise and __coro_frame
variables.
@@ -78,8 +78,19 @@ def do_test(self, stdlib_type):
],
)
-# Run until after the `co_yield`
process = self.process()
+
+# Break at a coroutine body
+lldbutil.continue_to_source_breakpoint(
+ self, process, "//
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ return name == g_this ||
+ // Artificial coroutine-related vari
hokein wrote:
> Did you configure your build with `LLDB_INCLUDE_TESTS=ON` and
> `LLDB_INCLUDE_PYTHON=ON`? Those CMake variables are necessary to get the API
> tests to run
Thanks! I was able to run the test locally now with `-DLLDB_INCLUDE_TESTS=On`,
`-DLLDB_ENABLE_PYTHON=On`, and all deps i
@@ -41,7 +41,11 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
hokein
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/71928
>From 1ac7e612bf6917af4e347407fb98affa9bb296c6 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH 1/2] [LLDB] Display artificial __promise and __coro_frame
variables.
@@ -41,7 +41,11 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
Michael
Michael137 wrote:
> Is there a way to run the tests under `lldb/test/API/` directory? `ninja
> check-lldb` doesn't seem to run these tests on my linux machine.
>
> ```
> ./bin/llvm-lit -sv
> /lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/
>
>
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff bd611264993f64decbce178d460caf1d1cb05f59
1ac7e612bf6917af4e347407fb98affa9bb296c6 --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
bd611264993f64decbce178d460caf1d1cb05f59..1ac7e612bf6917af4e347407fb98affa9bb296c6
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Haojian Wu (hokein)
Changes
See the discussion in #69309.
---
Full diff: https://github.com/llvm/llvm-project/pull/71928.diff
3 Files Affected:
- (modified)
lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp (+5-1)
-
https://github.com/hokein ready_for_review
https://github.com/llvm/llvm-project/pull/71928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
hokein wrote:
Is there a way to run the tests under `lldb/test/API/` directory? `ninja
check-lldb` doesn't seem to run these tests on my linux machine.
```
./bin/llvm-lit -sv
/lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/
Testing Time: 0.02s
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/71928
See the discussion in #69309.
>From 1ac7e612bf6917af4e347407fb98affa9bb296c6 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 10 Nov 2023 12:35:10 +0100
Subject: [PATCH] [LLDB] Display artificial __promise an
26 matches
Mail list logo
