https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/omjavaid approved this pull request.
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -783,6 +783,11 @@ void GDBRemoteRegisterContext::AArch64Reconfigure() {
std::optional svg_reg_value;
const RegisterInfo *svg_reg_info = m_reg_info_sp->GetRegisterInfo("svg");
if (svg_reg_info) {
+// When vg is written it is automatically made invalid. Writing vg
DavidSpickett wrote:
ping!
I know you're very busy at the moment, but if you have time to review this week
this is the most important patch I've got queued.
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
@@ -783,6 +783,11 @@ void GDBRemoteRegisterContext::AArch64Reconfigure() {
std::optional svg_reg_value;
const RegisterInfo *svg_reg_info = m_reg_info_sp->GetRegisterInfo("svg");
if (svg_reg_info) {
+// When vg is written it is automatically made invalid. Writing vg
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/66768
>From 8b292d573710e1c37227d6f80b9770220abd658e Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 22 Aug 2023 14:42:35 +0100
Subject: [PATCH 1/2] [lldb][AArch64] Invalidate SVG prior to reconfiguring
@@ -783,6 +783,11 @@ void GDBRemoteRegisterContext::AArch64Reconfigure() {
std::optional svg_reg_value;
const RegisterInfo *svg_reg_info = m_reg_info_sp->GetRegisterInfo("svg");
if (svg_reg_info) {
+// When vg is written it is automatically made invalid. Writing vg
@@ -783,6 +783,11 @@ void GDBRemoteRegisterContext::AArch64Reconfigure() {
std::optional svg_reg_value;
const RegisterInfo *svg_reg_info = m_reg_info_sp->GetRegisterInfo("svg");
if (svg_reg_info) {
+// When vg is written it is automatically made invalid. Writing vg
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/66768
>From 3d4834fd5ab994dd312b28b874e73f0807b117dc Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 22 Aug 2023 14:42:35 +0100
Subject: [PATCH] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA
DavidSpickett wrote:
I've just pushed a similar fix for SVE's VG
(https://github.com/llvm/llvm-project/commit/fdc265be26483be1e081ea3f1e11d78b8cc488af).
Fixes some test flakiness so I've pushed it directly.
https://github.com/llvm/llvm-project/pull/66768
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
This fixes a bug where writing vg during streaming mode could prevent you
reading za directly afterwards.
vg is invalided when the write happens. SVE is reconfigured by reading back the
new value from the remote. So far so good.
For SME,
DavidSpickett wrote:
Replaces https://reviews.llvm.org/D158514.
https://github.com/llvm/llvm-project/pull/66768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/66768
This fixes a bug where writing vg during streaming mode could prevent you
reading za directly afterwards.
vg is invalided when the write happens. SVE is reconfigured by reading back the
new value from
17 matches
Mail list logo
