[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

chelcassanova wrote: Closing this PR, we wanted to be able to do this _without_ using the `PythonDataObjects` class in the swig wrapper that contains callback functions but this looks to be unfeasible for callbacks that return SB objects https://github.com/llvm/llvm-project/pull/95318

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/95318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

https://github.com/bulbazord commented: Is this just moving code around? The summary says what you're doing but not why, what's the motivation? https://github.com/llvm/llvm-project/pull/95318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

@@ -0,0 +1,119 @@ +/* + Typemaps specific to callback functions in LLDB. If editing this file + use the Python C API to access Python objects instead of using PythonDataObjects. +*/ + +// For Log::LogOutputCallback +%typemap(in) (lldb::LogOutputCallback log_callback, void

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

@@ -0,0 +1,119 @@ +/* + Typemaps specific to callback functions in LLDB. If editing this file + use the Python C API to access Python objects instead of using PythonDataObjects. +*/ + +// For Log::LogOutputCallback +%typemap(in) (lldb::LogOutputCallback log_callback, void

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

@@ -0,0 +1,119 @@ +/* + Typemaps specific to callback functions in LLDB. If editing this file + use the Python C API to access Python objects instead of using PythonDataObjects. medismailben wrote: nit: it would be nice to put the Python C API documentation

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/95318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

https://github.com/medismailben requested changes to this pull request. https://github.com/llvm/llvm-project/pull/95318 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes This commit refactors the typemaps and static functions used in the SWIG typemaps and wrappers to be in their own SWIG files that are included in the main `python.swig` file. --- Full diff:

[Lldb-commits] [lldb] [lldb][swig] Refactor callback typemaps and functions (PR #95318)

https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/95318 This commit refactors the typemaps and static functions used in the SWIG typemaps and wrappers to be in their own SWIG files that are included in the main `python.swig` file. >From