rupprecht wrote:
> FYI @labath as the x86 bot owner.
I checked w/ them that
[lldb-x86_64-debian](https://lab.llvm.org/buildbot/#/builders/68) has
python3-pexpect (specifically 4.8) installed.
> > It should perhaps unset the variable first, I'll see if I can implement
> > that.
>
> [ec95379]
DavidSpickett wrote:
Done:
https://github.com/llvm/llvm-project/commit/ec8df555702d85511290742388d28016b69468de
/
https://github.com/llvm/llvm-zorg/commit/e08c692f75a922ee820ac8722f5033255913c195
https://github.com/llvm/llvm-project/pull/83191
___
l
bulbazord wrote:
@DavidSpickett If you haven't already, might I suggest looking into a CMake
setting I implemented last year? `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` --
this will cause your CMake configure step to fail if your bots are missing
python packages so that you know your bots are run
DavidSpickett wrote:
Arm and AArch64 bots now have pexpect 4.9.0 installed.
For Linaro's bots at least, we would be ok with you flipping
`LLDB_TEST_USE_VENDOR_PACKAGES` to `OFF` as the next step. This saves us
getting a change through zorg and should "just work" now.
https://github.com/llvm/l
DavidSpickett wrote:
> It should perhaps unset the variable first, I'll see if I can implement that.
https://github.com/llvm/llvm-project/commit/ec95379df363253ffcbbda21297417e703d5ccca
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits
DavidSpickett wrote:
FYI @labath as the x86 bot owner.
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
And a data point, AArch64 and Arm Linux are fine with pexpect-4.9.0. Still
working on getting it installed on the bot containers.
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llv
DavidSpickett wrote:
The way the cmake is written it seems that Py_pexpect_FOUND is set to false the
first time you run cmake. Then you install pexpect and lldb_find_python_module
bails early because Py_pexpect_FOUND is *still* set to false.
If you remove the CMake cache it'll then find pexpec
JDevlieghere wrote:
> @JDevlieghere @adrian-prantl we should consider adding this to the list of
> required python modules on our bots too and enforce it with
> `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS`? Probably not in this PR, but after
> we can get our bots configured correctly.
Added in 793
https://github.com/rupprecht closed
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
You need to update the PR description but otherwise LGTM.
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/rupprecht edited
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
13 matches
Mail list logo
