[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-13 Thread Pavel Labath via lldb-commits
labath wrote: Thanks. https://github.com/llvm/llvm-project/pull/93808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-12 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Pushed a fix https://github.com/llvm/llvm-project/pull/93808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-12 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: @dzhidzhoev I think @labath 's suggestion might fix this (LD_EXTRAS) https://github.com/llvm/llvm-project/pull/93808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-12 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: hi @dzhidzhoev, I think this commit is causing the arm lldb incremental bots to fail. Could you have a look or revert if you think the fix is not obvious? This is our most important bot, so it would be nice to get it green again

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/93808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-12 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/93808 >From eaf50dc4a1f5285676c16b59c4149483d94fb986 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Thu, 9 May 2024 04:53:23 + Subject: [PATCH] [lldb][test] Disable PIE for some API tests These

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-03 Thread Pavel Labath via lldb-commits
@@ -3,4 +3,8 @@ # C_SOURCES := b.c # EXE := b.out +ifndef PIE + LDFLAGS := -no-pie labath wrote: Setting LD_EXTRAS is the typical way to pass linker flags from here (the same for other files) https://github.com/llvm/llvm-project/pull/93808

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-03 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/93808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-03 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/93808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-06-03 Thread Pavel Labath via lldb-commits
labath wrote: > > Ok, I see now. It's an ld.bfd vs ld.lld thing. You probably have your clang > > configured to use lld. LLD does not put relocation addends into the data > > section (on both arm and intel). ld.bfd does, which is why this sort of > > happens to work there. Was your intention

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-05-31 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > Ok, I see now. It's an ld.bfd vs ld.lld thing. You probably have your clang > configured to use lld. LLD does not put relocation addends into the data > section (on both arm and intel). ld.bfd does, which is why this sort of > happens to work there. Was your intention to

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-05-31 Thread Pavel Labath via lldb-commits
labath wrote: Ok, I see now. It's an ld.bfd vs ld.lld thing. You probably have your clang configured to use lld. LLD does not put relocation addends into the data section (on both arm and intel). ld.bfd does, which is why this sort of happens to work there. Was your intention to test with

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-05-30 Thread Pavel Labath via lldb-commits
labath wrote: What do the failures look like? I tried to force -pie on some of the tests that you modified, and I couldn't get them to fail. Is this somehow specific to remote execution? https://github.com/llvm/llvm-project/pull/93808 ___

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-05-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes When PIE is enabled on a platform by default, these tests fail since the `target variable` command can't read a global string variable value before running an inferior process. --- Full diff:

[Lldb-commits] [lldb] [lldb][test] Disable PIE for some API tests (PR #93808)

2024-05-30 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/93808 When PIE is enabled on a platform by default, these tests fail since the `target variable` command can't read a global string variable value before running an inferior process. >From