https://github.com/rupprecht updated
https://github.com/llvm/llvm-project/pull/83191
>From d21ac756226a364603acd0180f9a06c23600acb1 Mon Sep 17 00:00:00 2001
From: Jordan Rupprecht
Date: Tue, 27 Feb 2024 13:25:12 -0800
Subject: [PATCH 1/2] [lldb][test] Exclude third_party packages by default
rupprecht wrote:
> Though maybe you intend this to break builds, that way obscure builders that
> we don't know about will still hear about this?
>
Yes, but I agree with your suggestion to land this with a default of `ON`,
which makes this change NFC. I can then switch it to `OFF` once known
DavidSpickett wrote:
Also are there known compatible/incompatible versions of pexpect? Is `pip
install pexpect` going to install something with significant API differences to
the vendored copy?
https://github.com/llvm/llvm-project/pull/83191
___
DavidSpickett wrote:
Though maybe you intend this to break builds, that way obscure builders that we
don't know about will still hear about this?
I can understand that angle, in which case do we want to make sure all known
builders have pexpect installed before this commit goes in? I will
DavidSpickett wrote:
> This introduces a LLDB_TEST_USE_VENDOR_PACKAGES cmake param that can be
> enabled, and the tests will continue loading that tree.
I get the intent but doing it this way is actually going to be more of an
issue. As changes to our bot config have to go through zorg, a
https://github.com/bulbazord approved this pull request.
LGTM
@JDevlieghere @adrian-prantl we should consider adding this to the list of
required python modules on our bots too and enforce it with
`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS`? Probably not in this PR, but after we
can get our bots
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jordan Rupprecht (rupprecht)
Changes
The goal here is to remove the third_party/Python/module tree, which LLDB tests
only use to `import pexpect`. This package is available on `pip`, and I believe
should not be hard to obtain.
However,
https://github.com/rupprecht created
https://github.com/llvm/llvm-project/pull/83191
The goal here is to remove the third_party/Python/module tree, which LLDB tests
only use to `import pexpect`. This package is available on `pip`, and I believe
should not be hard to obtain.
However, in case
