[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

rupprecht wrote: > Beautiful, thank you for working on this. After this change, what's left to > get us using the python-provided `unittest`? The giant lambda inside `_decorateTest` has one remaining `self` reference, which is `self.getDebugInfo()` -- i.e. the debug info specific variant

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

@@ -184,3 +187,144 @@ def hasChattyStderr(test_case): ): return True # The dynamic linker on the device will complain about unknown DT entries return False + + +def builder_module(): +return get_builder(sys.platform) + + +def getArchitecture(): +

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

https://github.com/rupprecht updated https://github.com/llvm/llvm-project/pull/72416 >From b3178bb93c0d414857732b08228987894df762d4 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Wed, 15 Nov 2023 08:58:17 -0800 Subject: [PATCH 1/2] [lldb][test] Move most `self` references out of

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

https://github.com/bulbazord approved this pull request. Beautiful, thank you for working on this. After this change, what's left to get us using the python-provided `unittest`? https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

medismailben wrote: Nice! LGTM with some nits. https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

@@ -1310,82 +1308,29 @@ def isAArch64Windows(self): def getArchitecture(self): """Returns the architecture in effect the test suite is running with.""" -module = builder_module() -arch = module.getArchitecture() -if arch == "amd64": -

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

@@ -1310,82 +1308,29 @@ def isAArch64Windows(self): def getArchitecture(self): """Returns the architecture in effect the test suite is running with.""" -module = builder_module() -arch = module.getArchitecture() -if arch == "amd64": -

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

@@ -184,3 +187,144 @@ def hasChattyStderr(test_case): ): return True # The dynamic linker on the device will complain about unknown DT entries return False + + +def builder_module(): +return get_builder(sys.platform) + + +def getArchitecture(): +

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

https://github.com/JDevlieghere approved this pull request.  Thanks for doing this! https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

https://github.com/rupprecht edited https://github.com/llvm/llvm-project/pull/72416 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes --- Patch is 22.83 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/72416.diff 3 Files Affected: - (modified)

[Lldb-commits] [lldb] [lldb][test] Remove `self` references from decorators (PR #72416)

https://github.com/rupprecht created https://github.com/llvm/llvm-project/pull/72416 None >From b3178bb93c0d414857732b08228987894df762d4 Mon Sep 17 00:00:00 2001 From: Jordan Rupprecht Date: Wed, 15 Nov 2023 08:58:17 -0800 Subject: [PATCH] [lldb][test] Move most `self` references out of