[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

2024-04-25 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/90144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

2024-04-25 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/90144 >From 3b66943d9c49fd5e71c2eb136b5bb3311e932bbc Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Thu, 25 Apr 2024 15:51:44 -0700 Subject: [PATCH 1/2] [lldb] Add SBValue::GetValueAsAddress API I previously

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

2024-04-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/90144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

2024-04-25 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM with the formatting and braces fixed. https://github.com/llvm/llvm-project/pull/90144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

2024-04-25 Thread Jonas Devlieghere via lldb-commits
@@ -909,6 +909,26 @@ uint64_t SBValue::GetValueAsUnsigned(uint64_t fail_value) { return fail_value; } +lldb::addr_t SBValue::GetValueAsAddress() { + addr_t fail_value = LLDB_INVALID_ADDRESS; + ValueLocker locker; + lldb::ValueObjectSP value_sp(GetSP(locker)); + if

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

2024-04-25 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 5ac744d72ad2a8d04e0ae869c4e30558dd8058e3...3b66943d9c49fd5e71c2eb136b5bb3311e932bbc

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

2024-04-25 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes I previously added this API via https://reviews.llvm.org/D142792 in 2023, along with changes to the ValueObject class to treat pointer types as addresses, and to annotate those ValueObjects with the

[Lldb-commits] [lldb] [lldb] Add SBValue::GetValueAsAddress API (PR #90144)

2024-04-25 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/90144 I previously added this API via https://reviews.llvm.org/D142792 in 2023, along with changes to the ValueObject class to treat pointer types as addresses, and to annotate those ValueObjects with the