kpdev wrote:
@jimingham Please take a look:
https://github.com/llvm/llvm-project/pull/67782#issuecomment-2047369473
https://github.com/llvm/llvm-project/pull/67782
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -0,0 +1,171 @@
+#include "LibCxx.h"
+#include "LibCxxStringInfoExtractor.h"
+
+#include "lldb/DataFormatters/FormattersHelpers.h"
+#include
+
+using namespace lldb;
+using namespace lldb_private;
+
+namespace {
+
+class StringFrontend : public SyntheticChildrenFrontEnd {
+
+pu
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/67782
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> Hello, @jimingham , first of all - sorry for the long delay in reply.
>
> I carefully read through all your messages once again and found, that I
> totally misunderstood some places, i.e. "Why isn't it enough to have the
> ValueObjectSynthetic's SetValueFromCString do this"
https://github.com/kpdev created https://github.com/llvm/llvm-project/pull/67782
Before this update strings has only DataFormatters, and therefore the way they
were printed was slightly different (see comment here:
https://github.com/llvm/llvm-project/blob/main/lldb/source/DataFormatters/Format
kpdev wrote:
Depends on:
https://github.com/llvm/llvm-project/pull/67309#issuecomment-1740657973
https://github.com/llvm/llvm-project/pull/67782
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
9284b03e87df5153fe425b6b81b8402f666deb18..433d3973716cc46e1ffd7044898189f845e536f6
lldb/
@@ -231,23 +244,39 @@ def cleanup():
"frame variable is",
substrs=[
multimap,
-"size=4",
-'[0] = (first = 1, second = "is")',
-'[1] = (first = 2, second = "smart")',
-'[2] =
jimingham wrote:
To clear up terminology... Strings had data formatters before AND after this
change. The difference is that you've switched from a "Summary Provider" data
formatter to a "Synthetic Child Provider" data formatter.
It looks like you've made the printing of std::strings less sp
jimingham wrote:
BTW, I have no problem with the general direction of this change. It makes a
lot more sense to ask a synthetic child provider to change a value - since it
does represent the value of the ValueObject - rather than the summary which is
just some free-form text. And being able
kpdev wrote:
> What is it about this change that is defeating the ValueObject printer from
> compressing this output onto one line? It looks like the contents that get
> printed are the same, so there's something about switching from a Summary
> provider to a child provider that's causing prob
kpdev wrote:
> BTW, I have no problem with the general direction of this change. It makes a
> lot more sense to ask a synthetic child provider to change a value - since it
> does represent the value of the ValueObject - rather than the summary which
> is just some free-form text. And being abl
jimingham wrote:
I don't know what the status of lldb-mi is, but lldb-vscode which does the same
job (be a DAP server) is under active development. So "this adaptor doesn't
use the better method to do X" shouldn't be a reason to not employ the better
method. We should just fix the adaptors.
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/67782
>From 374784cbaaffe9ca2bac716c996485783b959364 Mon Sep 17 00:00:00 2001
From: Pavel Kosov
Date: Tue, 23 Jan 2024 09:37:54 +0300
Subject: [PATCH] [LLDB] Add ability to update string during debugging
This is the last
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 22764918b5c1496970ab6bb1547535c554a06347
374784cbaaffe9ca2bac716c996485783b959364 --
jimingham wrote:
> On Oct 5, 2023, at 1:05 AM, Pavel Kosov ***@***.***> wrote:
>
>
> BTW, I have no problem with the general direction of this change. It makes a
> lot more sense to ask a synthetic child provider to change a value - since it
> does represent the value of the ValueObject - ra
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/67782
>From ccc9fb6be2f390cd894e0632cfded98f329f3059 Mon Sep 17 00:00:00 2001
From: Pavel Kosov
Date: Wed, 10 Apr 2024 14:45:49 +0300
Subject: [PATCH] [LLDB] Add ability to update string during debugging
This is the last
kpdev wrote:
Hello, @jimingham , first of all - sorry for the long delay in reply.
I carefully read through all your messages once again and found, that I totally
misunderstood some places, i.e. "Why isn't it enough to have the
ValueObjectSynthetic's SetValueFromCString do this" - I think it s
18 matches
Mail list logo
