https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> This seems reasonable. However, I note that on the page where we show how to
> write synthetic child providers, we say:
>
> def num_children(self): this call should return the number of children that
> you want your object to have
>
> That's actually not true - we pass the max
@@ -442,16 +443,19 @@ lldb::Format
FormatManager::GetSingleItemFormat(lldb::Format vector_format) {
}
bool FormatManager::ShouldPrintAsOneLiner(ValueObject &valobj) {
+ TargetSP target_sp = valobj.GetTargetSP();
// if settings say no oneline whatsoever
- if (valobj.GetTa
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/93946
>From 1e25ef1cc5ff4d12a3e5b85c8ea7cd30a3e0908e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 31 May 2024 10:06:19 +
Subject: [PATCH 1/2] [lldb] Avoid (unlimited) GetNumChildren calls when
printing va
jimingham wrote:
BTW, because the max number of children is probably getting ignored in the
wild, this has to be advisory, you can't require that:
val.GetNumChildren(max_children) <= max_children
I don't think you do that but it might be good to note the fact.
https://github.com/llvm/llvm-pro
jimingham wrote:
This seems reasonable. However, I note that on the page where we show how to
write synthetic child providers, we say:
def num_children(self):
this call should return the number of children that you want your object
to have
That's actually not true - we pass the max_
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/93946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/93946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -442,16 +443,19 @@ lldb::Format
FormatManager::GetSingleItemFormat(lldb::Format vector_format) {
}
bool FormatManager::ShouldPrintAsOneLiner(ValueObject &valobj) {
+ TargetSP target_sp = valobj.GetTargetSP();
// if settings say no oneline whatsoever
- if (valobj.GetTa
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/93946
>From 1e25ef1cc5ff4d12a3e5b85c8ea7cd30a3e0908e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 31 May 2024 10:06:19 +
Subject: [PATCH] [lldb] Avoid (unlimited) GetNumChildren calls when printing
values
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
a2bcb932f3130c3c18ceb06872da9002f6845c4b...957f0a85a0e0d2de9f34d00e28ba932e5affce86
lldb
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
For some data formatters, even getting the number of children can be an
expensive operations (e.g., needing to walk a linked list to determine the
number of elements). This is then wasted work when we know we
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/93946
For some data formatters, even getting the number of children can be an
expensive operations (e.g., needing to walk a linked list to determine the
number of elements). This is then wasted work when we know we wil
13 matches
Mail list logo
