[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-06 Thread Kevin Frei via lldb-commits
@@ -0,0 +1,4 @@ +add_subdirectory(Default) +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") + add_subdirectory(DebugSymbols) kevinfrei wrote: I'm switching my previous PR to be a "Debuginfod" SymbolLocator plugin, and I think this plugin name is far too general.

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71151 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/71151 >From 08eb0a2fef369c81c87c517811e634fd0cac7c6d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 2 Nov 2023 23:29:20 -0700 Subject: [PATCH] [lldb] Introduce a plugin to locate symbols This commit

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/71151 >From 234258ff47b075a7094b5d57bfc0a420c49c7edb Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 2 Nov 2023 23:29:20 -0700 Subject: [PATCH 1/2] [lldb] Convert LocateSymbolFile into a plugin This

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Alex Langford via lldb-commits
@@ -0,0 +1,23 @@ +//===-- SymbolLocator.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Alex Langford via lldb-commits
@@ -0,0 +1,91 @@ +//===-- SymbolLocatorDefault.cpp +//--===// bulbazord wrote: Formatting https://github.com/llvm/llvm-project/pull/71151 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Alex Langford via lldb-commits
@@ -0,0 +1,328 @@ +//===-- SymbolLocatorDebugSymbols.cpp +//--===// bulbazord wrote: Formatting https://github.com/llvm/llvm-project/pull/71151 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Alex Langford via lldb-commits
@@ -0,0 +1,45 @@ +//===-- SymbolLocatorDebugSymbols.h --*- C++ +//-*-===// bulbazord wrote: Formatting https://github.com/llvm/llvm-project/pull/71151 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/71151 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, all my comments were minor things I noticed. Thanks for doing this! https://github.com/llvm/llvm-project/pull/71151 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This commit contains the initial scaffolding to convert the functionality currently implemented in LocateSymbolFile to a plugin architecture. The plugin approach allows us to easily add new ways to

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71151 This commit contains the initial scaffolding to convert the functionality currently implemented in LocateSymbolFile to a plugin architecture. The plugin approach allows us to easily add new ways to find