https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/94783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I have merged https://github.com/llvm/llvm-project/pull/100387 to fix this
instead, because it needed some background knowledge to do correctly.
But never the less, thank you @xgupta for making the effort to do this PR, it
has uncovered some unsafe code that only recently
labath wrote:
> > The field this is consuming is actually 17 bytes long, because the process
> > name is in parenthesis.
>
> Ok then I am confused how this ever worked, but it sounds like scanf was
> never a great way to do this anyway?
The field it's overwriting is in a struct, so it has a
https://github.com/DavidSpickett requested changes to this pull request.
> The field this is consuming is actually 17 bytes long, because the process
> name is in parenthesis.
Ok then I am confused how this ever worked, but it sounds like scanf was never
a great way to do this anyway?
https://github.com/labath commented:
The field this is consuming is actually 17 bytes long, because the process name
is in parenthesis. I suspect this will cause the function to reject any process
whose name is longer than 13 characters.
The name field is actually quite hard to parse this way
DavidSpickett wrote:
The bot will complain again but we will ignore it :)
https://github.com/llvm/llvm-project/pull/94783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Please remove the formatting changes and limit this to just the specifier
change.
I know most of the time we'd want it formatted but for a fix as limited as
this, the formatting change just gets in the way, and not formatting it doesn't
block merging either.
Otherwise
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94783
>From 17d39d89ee723881063ecbea19caaa6806e4e095 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 15 Jun 2024 23:57:03 +0530
Subject: [PATCH 1/2] Resolved merge conflict
---
lldb/source/Host/linux/Host.cpp
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94783
>From 17d39d89ee723881063ecbea19caaa6806e4e095 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 15 Jun 2024 23:57:03 +0530
Subject: [PATCH 1/2] Resolved merge conflict
---
lldb/source/Host/linux/Host.cpp
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ef01c75d467df92b8c659307595aa74ed2290cd8
17d39d89ee723881063ecbea19caaa6806e4e095 --
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/94783
>From 17d39d89ee723881063ecbea19caaa6806e4e095 Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sat, 15 Jun 2024 23:57:03 +0530
Subject: [PATCH] Resolved merge conflict
---
lldb/source/Host/linux/Host.cpp | 2
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
13 matches
Mail list logo
