[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-04 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Pushed as ``` * d24d7edaef95 (2 minu..) fpiove.. [lldb][NFC] Delete unreachable code and dead │ variable in OptionArgParser │ * 3e98a285138a (2 minu..) fpiove.. [lld

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-04 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/74119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/74119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-01 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. 🎉 https://github.com/llvm/llvm-project/pull/74119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > > Github makes this look extremely complicated but in my editor this all > > looks pretty obvious. LGTM. > > Yeah, that's part of the reason I tried to break the changes into smaller > bits, but it still doesn't look as obvious as I wish it did I noticed that too late, b

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-01 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: > Github makes this look extremely complicated but in my editor this all looks > pretty obvious. LGTM. Yeah, that's part of the reason I tried to break the changes into smaller bits, but it still doesn't look as obvious as I wish it did https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-01 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/74119 >From d4143eea927eed4f4f0efaa9e1657de5f452a257 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Fri, 1 Dec 2023 09:07:11 -0800 Subject: [PATCH 1/3] [lldb][NFC] Remove unnecessary std::string

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Github makes this look extremely complicated but in my editor this all looks pretty obvious. LGTM. https://github.com/llvm/llvm-project/pull/74119 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [lldb] Delete unreachable code and unnecessary string conversions (PR #74119)

2023-12-01 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/74119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits