felipepiovezan wrote:
Pushed as
```
* d24d7edaef95 (2 minu..) fpiove.. [lldb][NFC] Delete unreachable code and dead
│
variable in OptionArgParser
│
* 3e98a285138a (2 minu..) fpiove..
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/74119
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/74119
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/74119
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> > Github makes this look extremely complicated but in my editor this all
> > looks pretty obvious. LGTM.
>
> Yeah, that's part of the reason I tried to break the changes into smaller
> bits, but it still doesn't look as obvious as I wish it did
I noticed that too late,
felipepiovezan wrote:
> Github makes this look extremely complicated but in my editor this all looks
> pretty obvious. LGTM.
Yeah, that's part of the reason I tried to break the changes into smaller bits,
but it still doesn't look as obvious as I wish it did
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/74119
>From d4143eea927eed4f4f0efaa9e1657de5f452a257 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 1 Dec 2023 09:07:11 -0800
Subject: [PATCH 1/3] [lldb][NFC] Remove unnecessary
https://github.com/JDevlieghere approved this pull request.
Github makes this look extremely complicated but in my editor this all looks
pretty obvious. LGTM.
https://github.com/llvm/llvm-project/pull/74119
___
lldb-commits mailing list
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/74119
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
