nico wrote:
This doesn't build on Linux: http://45.33.8.238/linux/130329/step_4.txt
Please take a look and revert for now if it takes a while to fix.
(Looks like you added a definition on non apple; maybe the declaration is just
still missing)
https://github.com/llvm/llvm-project/pull/80890
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> @clayborg The idea behind the feature is to get symbols for things that are
> relevant to the user. Right now, that's only hooked up for images that appear
> in the stack trace, but there are certainly other places this would be
> useful. So yeah, I absolutely expect this to
JDevlieghere wrote:
Rebased & renamed the property to `symbols.auto-download`. I think all the
review comments have been addressed. The only oustanding question is if
@clayborg wants to have an additional setting for
`symbols.auto-download-stack-symbols`.
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/80890
>From 8846fb6cdb83b0364238bd74a99e97c1dba604a2 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 6 Feb 2024 16:25:37 -0800
Subject: [PATCH] [lldb] Expand background symbol lookup
LLDB has a
JDevlieghere wrote:
@clayborg The idea behind the feature is to get symbols for things that are
relevant to the user. Right now, that's only hooked up for images that appear
in the stack trace, but there are certainly other places this would be useful.
So yeah, I absolutely expect this to
clayborg wrote:
Does this setting only apply to the downloading of symbols that are auto
downloaded for stack traces? Or does it apply to any other areas that auto
download stuff? Do we want a setting to control the auto downloading of symbols
to clarify? Something like:
```
(lldb) settings
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
@@ -47,6 +47,26 @@ class UUID;
class VariableList;
struct ModuleFunctionSearchOptions;
+static constexpr OptionEnumValueElement g_download_enum_values[] = {
+{
+lldb::eSymbolDownloadOff,
+"off",
+"Disable downloading symbols.",
+},
+{
+
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
https://github.com/bulbazord approved this pull request.
I'm happy w/ the name. Thanks!
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/80890
>From d0696a22e07678e8b7a0dd78df0c873aa89deacb Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 6 Feb 2024 16:25:37 -0800
Subject: [PATCH] [lldb] Expand background symbol lookup
LLDB has a
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
jasonmolenda wrote:
I like this change, this will be a very handy capability for people debugging
corefiles & live sessions on remote computers when they have a mechanism to
find the binaries and/or debug info for those processes, without needing to
download all of them. One change I would
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/80890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
@@ -5,10 +5,11 @@ let Definition = "modulelist" in {
Global,
DefaultTrue,
Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-file-search-paths and directory of
the executable are always checked
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
LLDB has a setting (symbols.enable-background-lookup) that calls dsymForUUID on
a background thread for images as they appear in the current backtrace.
Originally, the laziness of only looking up
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/80890
LLDB has a setting (symbols.enable-background-lookup) that calls dsymForUUID on
a background thread for images as they appear in the current backtrace.
Originally, the laziness of only looking up symbols
28 matches
Mail list logo
