JDevlieghere wrote:
Thank you @antmox and @DavidSpickett for following up on this.
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
antmox wrote:
Yes, thanks @DavidSpickett
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I've skipped it entirely in
https://github.com/llvm/llvm-project/commit/ceec9a7874af2eea8b00b5616fad388ccfa2b4f3.
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
DavidSpickett wrote:
@antmox You could remove the expected failure marker and see what the result is
then. It will be less confusing.
It may be that it does pass, but occasionally times out for another reason.
Though that is weird given that all the server parts involved are mocks.
antmox wrote:
Hi! Could this commit cause the lldb-aarch64-windows bot failure ?
https://lab.llvm.org/buildbot/#/builders/219/builds/6086
https://lab.llvm.org/buildbot/#/builders/219/builds/6076
Not sure if it's an unexpected pass or a timeout.
Could you please take a look ?
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Lgtm
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/68050
>From c83435474699ba6ca5ff57bcb1dacaef0987f4b4 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 3 Oct 2023 08:41:01 -0700
Subject: [PATCH] [lldb] Expose Platform::Attach through the SB API
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo _info) {
});
}
+SBProcess SBPlatform::Attach(SBAttachInfo _info,
+ const SBDebugger , SBTarget ,
JDevlieghere wrote:
- `attach_info` cannot be const because
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
Looks fine to me, but I want to really make sure we get this interface right.
Left some comments inline.
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo _info) {
});
}
+SBProcess SBPlatform::Attach(SBAttachInfo _info,
+ const SBDebugger , SBTarget ,
+ SBError ) {
+ LLDB_INSTRUMENT_VA(this, attach_info);
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo _info) {
});
}
+SBProcess SBPlatform::Attach(SBAttachInfo _info,
+ const SBDebugger , SBTarget ,
bulbazord wrote:
I'd like to see the `attach_info` parameter marked
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -19,6 +20,7 @@ struct PlatformShellCommand;
namespace lldb {
class SBLaunchInfo;
+class SBAttachInfo;
bulbazord wrote:
sort
https://github.com/llvm/llvm-project/pull/68050
___
lldb-commits mailing list
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Expose Platform::Attach through the SB API.
rdar://116188959
---
Full diff: https://github.com/llvm/llvm-project/pull/68050.diff
7 Files Affected:
- (modified) lldb/include/lldb/API/SBAttachInfo.h (+1)
- (modified)
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/68050
Expose Platform::Attach through the SB API.
rdar://116188959
>From 6cf631f5acf3eb18e7cf12a2b996c9f974a360e2 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 1 Oct 2023 20:48:50 -0700
Subject:
17 matches
Mail list logo
