[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

2024-06-06 Thread Jonas Devlieghere via lldb-commits
@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate( case DW_OP_eq: if (stack.size() < 2) { return llvm::createStringError( -"Expression stack needs at least 2 items for DW_OP_eq."); +"expression stack needs at least 2 items

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

2024-06-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/94554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/94554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate( case DW_OP_eq: if (stack.size() < 2) { return llvm::createStringError( -"Expression stack needs at least 2 items for DW_OP_eq."); +"expression stack needs at least 2 items

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

2024-06-05 Thread Adrian Prantl via lldb-commits
@@ -1657,7 +1650,7 @@ llvm::Expected DWARFExpression::Evaluate( case DW_OP_eq: if (stack.size() < 2) { return llvm::createStringError( -"Expression stack needs at least 2 items for DW_OP_eq."); +"expression stack needs at least 2 items

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

2024-06-05 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/94554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

2024-06-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This patch make all errors start with a lowercase letter and removes trailing periods and newlines. This fixes inconsistencies between error messages and facilitate concatenating them. --- Patch

[Lldb-commits] [lldb] [lldb] Fix inconsistencies in DWARFExpression errors (PR #94554)

2024-06-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/94554 This patch make all errors start with a lowercase letter and removes trailing periods and newlines. This fixes inconsistencies between error messages and facilitate concatenating them. >From