https://github.com/labath created
https://github.com/llvm/llvm-project/pull/93458
Module names can be matched either by a full path or just their basename. The
completion machinery tried to do both, but had several bugs:
- it always inserted the basename as a completion candidate, even if the s
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Module names can be matched either by a full path or just their basename. The
completion machinery tried to do both, but had several bugs:
- it always inserted the basename as a completion candidate, even if th
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
80b78f5fb30c43cd88f0d096081bc7f1509b0110...aca5ab852854a46ba5443864c555d5479956d05d
lldb/
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/93458
>From 824ad3beb35adb83600e3d4dbce7c6e274fca1a1 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 27 May 2024 11:02:56 +
Subject: [PATCH] [lldb] Fix module name tab completion
Module names can be matched
@@ -297,8 +312,9 @@ class ModuleCompleter : public Completer {
void DoCompletion(SearchFilter *filter) override { filter->Search(*this); }
private:
- const char *m_file_name;
- const char *m_dir_name;
+ std::optional m_file_name;
DavidSpickett wrote:
Unl
@@ -906,3 +906,38 @@ def test_ambiguous_command(self):
def test_ambiguous_subcommand(self):
"""Test completing a subcommand of an ambiguous command"""
self.complete_from_to("settings s ta", [])
+
+def test_shlib_name(self):
+self.build()
+
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/93458
>From 824ad3beb35adb83600e3d4dbce7c6e274fca1a1 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 27 May 2024 11:02:56 +
Subject: [PATCH 1/2] [lldb] Fix module name tab completion
Module names can be matc
@@ -906,3 +906,38 @@ def test_ambiguous_command(self):
def test_ambiguous_subcommand(self):
"""Test completing a subcommand of an ambiguous command"""
self.complete_from_to("settings s ta", [])
+
+def test_shlib_name(self):
+self.build()
+
@@ -297,8 +312,9 @@ class ModuleCompleter : public Completer {
void DoCompletion(SearchFilter *filter) override { filter->Search(*this); }
private:
- const char *m_file_name;
- const char *m_dir_name;
+ std::optional m_file_name;
labath wrote:
Yeah, this
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/93458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Looks like this is breaking the macOS CI:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/2534/execution/node/97/log
```
==
FAIL: test_shlib_name (TestCompletion.CommandLineCompletionTestCase)
labath wrote:
> Mind taking a look @labath ?
I think I know how to fix this, just a sec.
https://github.com/llvm/llvm-project/pull/93458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
13 matches
Mail list logo
