[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'll be cheeky and assume this is fine to go in. https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-13 Thread David Spickett via lldb-commits
> I would never never write Python code that ugly. As usual with formatting the conclusions were as long as the same strange decisions are made consistently, it's worth doing. Discussion: https://discourse.llvm.org/t/python-code-style-and-reformatting-status-update/70641/13 Overall project docs:

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Oh nice! I was unsuccessfully looking in the LLDb subdir because I had assumed this was LLDB-specific! https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Have (should we) we documented that we format all python code with black > somewhere and how to install the tool? https://llvm.org/docs/CodingStandards.html#python-version-and-source-code-formatting https://github.com/llvm/llvm-project/pull/66053

Re: [Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread Jim Ingham via lldb-commits
Is there any chance we can use something other than black. I would never never write Python code that ugly. Jim > On Sep 12, 2023, at 8:47 AM, Adrian Prantl via lldb-commits > wrote: > > > adrian-prantl wrote: > > Have (should we) we documented that we format all python code with black

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Have (should we) we documented that we format all python code with black somewhere and how to install the tool? https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Using: black --exclude "third_party/" ./lldb/ -- Patch is 108.25 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/66053.diff 17 Files Affected: - (modified) lldb/scripts/analyze-project-deps.py

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread via lldb-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

2023-09-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/66053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits