[Lldb-commits] [lldb] [lldb] Improve mid-function epilogue scanning for x86 (PR #110965)

2024-10-03 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/110965 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve mid-function epilogue scanning for x86 (PR #110965)

2024-10-03 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. This LGTM! Thanks a lot of fixing it. Your comments match my observations and I tested this patch with a test case where we stop on every instruction of a few functions and assert we can unwind correctly. https://github.com/llvm/llv

[Lldb-commits] [lldb] [lldb] Improve mid-function epilogue scanning for x86 (PR #110965)

2024-10-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c1343a29216f08ec762b3e58572e5c3e41f6f285 8deef52bd49a54c8ea23d97460641d01d0daf898 --e

[Lldb-commits] [lldb] [lldb] Improve mid-function epilogue scanning for x86 (PR #110965)

2024-10-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The x86 assembly instruction scanner creates incorrect UnwindPlans when a mid-function epilogue has a non-epilogue instruction in it. The x86 instruction analysis which creates an UnwindPlan handles mid

[Lldb-commits] [lldb] [lldb] Improve mid-function epilogue scanning for x86 (PR #110965)

2024-10-03 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/110965 The x86 assembly instruction scanner creates incorrect UnwindPlans when a mid-function epilogue has a non-epilogue instruction in it. The x86 instruction analysis which creates an UnwindPlan handles mid-fu