https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/71458
Read the MD5 checksum from DWARF line tables and store it in the
corresponding support files.
>From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 6 Nov
JDevlieghere wrote:
Depends on #71457.
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Read the MD5 checksum from DWARF line tables and store it in the
corresponding support files.
---
Full diff: https://github.com/llvm/llvm-project/pull/71458.diff
9 Files Affected:
- (added) lldb/i
https://github.com/bulbazord approved this pull request.
the dwarf line tables patch LGTM
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
I would love to see if we can do this without increasing the size of FileSpec
objects. Can we have the DWARF line tables store a FileSpec + checksum and do
its warning without making every file object contain a checksum object
@@ -443,6 +455,9 @@ class FileSpec {
/// The unique'd filename path.
ConstString m_filename;
+ /// The optional MD5 checksum of the file.
+ Checksum m_checksum;
+
clayborg wrote:
We are increasing the size of all FileSpec objects by 16 bytes here. Is. i
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/71458
>From 5673248f1f19145cbbb0435177b6a5ed425fa1c0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 24 Oct 2023 16:14:27 -0700
Subject: [PATCH] [lldb] Read Checksum from DWARF line tables
Read the MD
@@ -443,6 +455,9 @@ class FileSpec {
/// The unique'd filename path.
ConstString m_filename;
+ /// The optional MD5 checksum of the file.
+ Checksum m_checksum;
+
JDevlieghere wrote:
To close the loop on this for others, Greg measured the impact of the
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dyung wrote:
Hi @JDevlieghere, this change seems to be causing 59 test failures in the
cross-project-test suite. Can you take a look?
https://lab.llvm.org/buildbot/#/builders/217/builds/30979
https://lab.llvm.org/buildbot/#/builders/243/builds/15142
https://github.com/llvm/llvm-project/pull/71
JDevlieghere wrote:
> Hi @JDevlieghere, this change seems to be causing 59 test failures in the
> cross-project-test suite. Can you take a look?
>
> https://lab.llvm.org/buildbot/#/builders/217/builds/30979
> https://lab.llvm.org/buildbot/#/builders/243/builds/15142
I'll revert the change, bu
JDevlieghere wrote:
Reverted in #71864.
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dyung wrote:
> > Hi @JDevlieghere, this change seems to be causing 59 test failures in the
> > cross-project-test suite. Can you take a look?
> > https://lab.llvm.org/buildbot/#/builders/217/builds/30979
> > https://lab.llvm.org/buildbot/#/builders/243/builds/15142
>
> I'll revert the change,
dyung wrote:
> Reverted in #71864.
Thanks, they seem to be passing now:
https://lab.llvm.org/buildbot/#/builders/243/builds/15146
https://lab.llvm.org/buildbot/#/builders/217/builds/30989
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commit
JDevlieghere wrote:
It was also passing before with the change, so the issue isn't fully
deterministic: https://lab.llvm.org/buildbot/#/builders/217/builds/30986
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commi
dyung wrote:
> It was also passing before with the change, so the issue isn't fully
> deterministic: https://lab.llvm.org/buildbot/#/builders/217/builds/30986
That was me forcing the build of the commit immediately preceding yours to
verify it was passing:
`reason
A build was forced by '': Bu
dyung wrote:
For completeness, here is where I forced a build of the commit immediately
preceding yours:
https://lab.llvm.org/buildbot/#/builders/217/builds/30986
Note the git checkout step:
```
...
using PTY: False
2984156fd34a6969c7461b228d90b72711e3797c
program finished with exit code 0
...
JDevlieghere wrote:
That would've been helpful information to include in your original message and
saved me the time of having to go through the logs.
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.ll
dyung wrote:
> That would've been helpful information to include in your original message
> and saved me the time of having to go through the logs.
Sorry about that, I'll be sure to do so next time.
https://github.com/llvm/llvm-project/pull/71458
___
21 matches
Mail list logo
