https://github.com/usama54321 closed
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
usama54321 wrote:
Thanks everyone!
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/usama54321 updated
https://github.com/llvm/llvm-project/pull/69388
>From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001
From: usama
Date: Wed, 18 Oct 2023 17:16:50 -0700
Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan
This commit refactors
https://github.com/bulbazord approved this pull request.
Thanks for breaking it up, that made it easier for me to review.
I don't see any issues with it right now, so LGTM.
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
@@ -0,0 +1,120 @@
+//===-- InstrumentationRuntimeASan.cpp
===//
JDevlieghere wrote:
I know it's a bit unwieldy, but should this file be called
`InstrumentationRuntimeASanLibsanitizers`?
https://github.com/JDevlieghere approved this pull request.
LGTM with the filename updated.
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,5 +1,7 @@
+add_subdirectory(Libsanitizers)
usama54321 wrote:
More specifically, I have named the file
`ASanLibsanitizers/InstrumentationRuntimeASan.cpp` instead of
`ASanLibsanitizers/InstrumentationRuntimeASanLibsanitizers.cpp`
https://github.com/usama54321 updated
https://github.com/llvm/llvm-project/pull/69388
>From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001
From: usama
Date: Wed, 18 Oct 2023 17:16:50 -0700
Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan
This commit refactors
https://github.com/usama54321 updated
https://github.com/llvm/llvm-project/pull/69388
>From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001
From: usama
Date: Wed, 18 Oct 2023 17:16:50 -0700
Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan
This commit refactors
usama54321 wrote:
Thanks a lot for the feedback @bulbazord and @JDevlieghere. I have updated the
PR. I will appreciate any feedback about the directory/file naming convention
after the update.
https://github.com/llvm/llvm-project/pull/69388
___
@@ -1,5 +1,7 @@
+add_subdirectory(Libsanitizers)
usama54321 wrote:
I moved the plugin in the parent directory. However, I was not sure how to name
the plugin so I have currently named the folder as ASanLibsanitizers and named
the files as
https://github.com/usama54321 updated
https://github.com/llvm/llvm-project/pull/69388
>From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001
From: usama
Date: Wed, 18 Oct 2023 17:16:50 -0700
Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan
This commit refactors
https://github.com/usama54321 updated
https://github.com/llvm/llvm-project/pull/69388
>From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001
From: usama
Date: Wed, 18 Oct 2023 17:16:50 -0700
Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan
This commit refactors
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
https://github.com/bulbazord commented:
Overall looks alright to me. Aside from the inline feedback, I have 2 general
pieces of feedback.
1. It might be easier if you broke this up into 2 separate commits. You're
doing 2 things in 1 commit: Refactoring InstrumentationRuntimeAsan and adding a
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -1,5 +1,7 @@
+add_subdirectory(Libsanitizers)
bulbazord wrote:
+1
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -0,0 +1,241 @@
+//===-- ReportRetriever.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0
@@ -280,29 +81,13 @@ void InstrumentationRuntimeASan::Activate() {
if (!process_sp)
return;
- ConstString symbol_name("_ZN6__asanL7AsanDieEv");
- const Symbol *symbol = GetRuntimeModuleSP()->FindFirstSymbolWithNameAndType(
- symbol_name, eSymbolTypeCode);
+
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,56 @@
+//===-- InstrumentationRuntimeLibsanitizers.h *-
C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
JDevlieghere wrote:
Fix ASCII art
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing
@@ -0,0 +1,31 @@
+//===-- ReportRetriever.h *- C++ -*-===//
JDevlieghere wrote:
Fix ASCII art
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
@@ -1,5 +1,7 @@
+add_subdirectory(Libsanitizers)
JDevlieghere wrote:
Rather than living under the Asan plugin, it seems like his should be living at
the same level. If there's shared code between the two plugins, we should hoist
that up into a separate library
@@ -0,0 +1,56 @@
+//===-- InstrumentationRuntimeLibsanitizers.h *-
C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+//
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cf670d5e56d14afa7c3e005c13588fd7b5ee75ce
76493df4dcfc055ec0b4f7d745f3799b904f679d --
usama54321 wrote:
@llvm-ci test
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/usama54321 updated
https://github.com/llvm/llvm-project/pull/69388
>From 3ee63c7dfd8b92ac8738d19bd3cebffeccfd59ec Mon Sep 17 00:00:00 2001
From: usama
Date: Tue, 17 Oct 2023 14:35:04 -0700
Subject: [PATCH] [lldb] Refactor InstrumentationRuntimeAsan and add a new
plugin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Usama Hameed (usama54321)
Changes
[lldb] Refactor InstrumentationRuntimeAsan and add a new plugin
InstrumentationRuntimeLibsanitizers.
This commit adds InstrumentationRuntimeLibsanitizers, a new runtime plugin for
ASan. The plugin
39 matches
Mail list logo
