https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/89685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Troy-Butler wrote:
> Otherwise this LGTM!
> Even though you link the issue, I would recommend also summarizing the issue
> in the commit. Something like "The current code is checking the validity of
> `obj` twice, instead of checking the new `str_obj` pointer."
>
> Otherwise this LGTM!
I
https://github.com/Troy-Butler edited
https://github.com/llvm/llvm-project/pull/89685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Even though you link the issue, I would recommend also summarizing the issue in
the commit. Something like "The current code is checking the validity of `obj`
twice, instead of checking the new `str_obj` pointer."
Otherwise this
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Troy Butler (Troy-Butler)
Changes
Addresses issue #87243.
---
Full diff: https://github.com/llvm/llvm-project/pull/89685.diff
1 Files Affected:
- (modified) lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
(+1-1)
https://github.com/Troy-Butler created
https://github.com/llvm/llvm-project/pull/89685
Addresses issue #87243.
>From 20c093a1cd51adab9387e9a15fca7c8b592f3f21 Mon Sep 17 00:00:00 2001
From: Troy-Butler
Date: Mon, 22 Apr 2024 19:17:08 -0400
Subject: [PATCH] [lldb] Replace always-false
