https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/69231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> There are probably a lot of functions that could be converted from a "Stream
> *" to "Stream &".
Yes, when I have a spare 5-10 minutes I pick a function and convert it. I don't
want to end up with a huge diff that is difficult to merge downstream so I do
it piecemeal.
clayborg wrote:
There are probably a lot of functions that could be converted from a "Stream *"
to "Stream &".
https://github.com/llvm/llvm-project/pull/69231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/69231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
This function always expects the pointer to be valid, a reference seems more
appropriate.
---
Full diff: https://github.com/llvm/llvm-project/pull/69231.diff
5 Files Affected:
- (modified)
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/69231
This function always expects the pointer to be valid, a reference seems more
appropriate.
>From fd70abe32d822be5a791f8650c86ca61a86fa755 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 16 Oct 2023
