https://github.com/labath closed https://github.com/llvm/llvm-project/pull/94455
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
This is much nicer. I would actually prefer we returned names that are ""
rather than nullptr, but in any case I agree there's no particular reason to
make that a contract.
https://github.com/llvm/llvm-project/pull/94455
@@ -46,75 +46,116 @@ lldb::ValueObjectSP
ValueObjectConstResultImpl::Dereference(Status ) {
return m_impl_backend->ValueObject::Dereference(error);
}
-ValueObject *ValueObjectConstResultImpl::CreateChildAtIndex(
-size_t idx, bool synthetic_array_member, int32_t
@@ -46,75 +46,116 @@ lldb::ValueObjectSP
ValueObjectConstResultImpl::Dereference(Status ) {
return m_impl_backend->ValueObject::Dereference(error);
}
-ValueObject *ValueObjectConstResultImpl::CreateChildAtIndex(
-size_t idx, bool synthetic_array_member, int32_t
@@ -488,66 +488,85 @@ void ValueObject::SetNumChildren(uint32_t num_children) {
m_children.SetChildrenCount(num_children);
}
-ValueObject *ValueObject::CreateChildAtIndex(size_t idx,
- bool synthetic_array_member,
-
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The the function is doing two fairly different things, depending on how it is
called. While this allows for some code reuse, it also makes it hard to
override it correctly. Possibly for this reason
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/94455
>From d3d666886d6397bb031a3ad88f147fb9b1e2b3ed Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 5 Jun 2024 10:21:10 +
Subject: [PATCH] [lldb] Split ValueObject::CreateChildAtIndex into two
functions
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/94455
The the function is doing two fairly different things, depending on how it is
called. While this allows for some code reuse, it also makes it hard to
override it correctly. Possibly for this reason
