https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/96256
The Platform class currently has two functions to resolve an executable:
`ResolveExecutable` and `ResolveRemoteExecutable`. The former strictly deals
with local files while the latter can handle potentially
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
The Platform class currently has two functions to resolve an executable:
`ResolveExecutable` and `ResolveRemoteExecutable`. The former strictly deals
with local files while the latter can handle pot
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/96256
>From 41f7b780548ccfc15ad22da51742f1809c34c103 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 20 Jun 2024 13:51:53 -0700
Subject: [PATCH] [lldb] Unify Platform::ResolveExecutable duplication
Th
https://github.com/jasonmolenda approved this pull request.
LGTM, nice cleanup.
https://github.com/llvm/llvm-project/pull/96256
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/96256
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Good stuff.
https://github.com/llvm/llvm-project/pull/96256
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1004,10 +1004,7 @@ class Platform : public PluginInterface {
virtual const char *GetCacheHostname();
- virtual Status
- ResolveRemoteExecutable(const ModuleSpec &module_spec,
- lldb::ModuleSP &exe_module_sp,
- const Fi
@@ -1004,10 +1004,7 @@ class Platform : public PluginInterface {
virtual const char *GetCacheHostname();
- virtual Status
- ResolveRemoteExecutable(const ModuleSpec &module_spec,
- lldb::ModuleSP &exe_module_sp,
- const Fi
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/96256
>From 41f7b780548ccfc15ad22da51742f1809c34c103 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 20 Jun 2024 13:51:53 -0700
Subject: [PATCH 1/2] [lldb] Unify Platform::ResolveExecutable duplication
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/96256
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
It seems this patch breaks the following tests on cross setups:
```
Failed Tests (6):
lldb-api :: commands/process/attach/TestProcessAttach.py
lldb-api :: commands/process/detach-resumes/TestDetachResumes.py
lldb-api :: functionalities/dyld-exec-linux/TestDyldExecLinux.py
clayborg wrote:
We think this broke Android debugging on our end. We are investigating.
https://github.com/llvm/llvm-project/pull/96256
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
clayborg wrote:
This did indeed break Android debugging. We reverted this in our repo and
functionality was restored
https://github.com/llvm/llvm-project/pull/96256
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
13 matches
Mail list logo
