aganea wrote:
This is breaking the github CI as seen here:
https://buildkite.com/llvm-project/github-pull-requests/builds/73339#01902659-9fbc-44d2-9a5b-783f5af41b78.
Should we add the "packaging" module to
https://github.com/llvm/llvm-project/blob/main/lldb/test/requirements.txt ?
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mysterymath wrote:
@JDevlieghere , we just landed a patch that adds packaging for Fuchsia. Should
be good to go ahead.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere wrote:
Thanks for checking @mysterymath. Based on your response it sounds like we have
a path forward for the Fuchsia. Please let me know when it's safe to land this.
I'll add `packaging` to `requirements.txt` that was added in #94220.
labath wrote:
> > That said, using a package designed (AIUI) for python versions for parsing
> > versions of gcc/clang does strike me as somewhat... unusual, even if it
> > does work, so _**maybe**_ there is case to be made for writing something
> > custom (I'm not sure if we really need
mysterymath wrote:
> We have other packages the test suite relies on (pexpect, psutil, etc) so it
> seemed reasonable, but if folks feel strongly about it we can maintain our
> own "version parsing".
Notably the other packages are optional; the lion's share of the test suite can
be run
JDevlieghere wrote:
> FWIW, there appears to be an actual arch package for this
> https://archlinux.org/packages/extra/any/python-packaging/, so it shouldn't
> be (I think -- I'm not an Arch user) necessary to install `pip`.
Homebrew on macOS works similarly, it has a
JDevlieghere wrote:
> That said, using a package designed (AIUI) for python versions for parsing
> versions of gcc/clang does strike me as somewhat... unusual, even if it does
> work, so _**maybe**_ there is case to be made for writing something custom
> (I'm not sure if we really need
labath wrote:
> @labath Does your ✅ mean the
> [debian](https://lab.llvm.org/buildbot/#/builders/68) bot has this package
> installed?
Affirmative.
> Did a bit of digging around; it looks like at the very least the Arch Linux
> python package and the Python docker container don't contain
mysterymath wrote:
Did a bit of digging around; it looks like at the very least the Arch Linux
python package and the Python docker container don't contain the `packaging`
library.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits
mysterymath wrote:
We don't have `pexpect` either; instead the tests that require it are disabled.
Our build is as hermetic as possible; even if the package were available in the
Python on the bots, we wouldn't be able to use it, since we don't make use of
the Python on the bots, for the most
JDevlieghere wrote:
GreenDragon now has `packaging` and based on David's message, the Linaro bots
do as well.
@labath Does your ✅ mean the
[debian](https://lab.llvm.org/buildbot/#/builders/68) bot has this package
installed?
@mysterymath Can you install this package on the Fuchia bots? I
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/93712
>From 4666a6a6470fc91ed17a9e60624a005dc97c4531 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 29 May 2024 10:36:47 -0700
Subject: [PATCH 1/2] [lldb] Use packaging module instead of
@@ -519,9 +519,9 @@ def _find_windows_sdk_in_registry_view(self, view):
# Windows SDK version numbers consist of 4 dotted components, so we
# have to use LooseVersion, as StrictVersion supports 3 or fewer.
JDevlieghere wrote:
No, it
DavidSpickett wrote:
`packaging` is already installed on Linaro's bots, so we're ok with this.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -519,9 +519,9 @@ def _find_windows_sdk_in_registry_view(self, view):
# Windows SDK version numbers consist of 4 dotted components, so we
# have to use LooseVersion, as StrictVersion supports 3 or fewer.
DavidSpickett wrote:
Does
@@ -1,6 +1,6 @@
# System modules
from functools import wraps
-from pkg_resources import packaging
+from packaging.version import parse
labath wrote:
```suggestion
from packaging import version
```
`parse` sounds too generic to be imported by base name alone
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> At least at present, this will probably break Fuchsia's build; the Python we
> ship includes `pkg_resources` but not `packaging`. Is the default `cpython`
> build from source intended to build and install `packaging`? Is this
> something that changed recently?
I'm not
mysterymath wrote:
At least at present, this will probably break Fuchsia's build; the Python we
ship includes `pkg_resources` but not `packaging`. Is the default `cpython`
build from source intended to build and install `packaging`? Is this something
that changed recently?
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rupprecht approved this pull request.
LGTM, but heads up for @mysterymath if this causes issues w/ Fuchsia's build
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Use the packaging [1] module for parsing version numbers, instead of
pkg_resources which is distributed with setuptools. I recently switched over to
using the latter, knowing it was deprecated (in
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/93712
Use the packaging [1] module for parsing version numbers, instead of
pkg_resources which is distributed with setuptools. I recently switched over to
using the latter, knowing it was deprecated (in favor of
27 matches
Mail list logo
