https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/81541
This implements functionality to handle `DataBreakpointInfo` request and
`SetDataBreakpoints` request.
It doesn't handle the case when `name` is an expression, see Todo comment for
details.
This is based on t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This implements functionality to handle `DataBreakpointInfo` request and
`SetDataBreakpoints` request.
It doesn't handle the case when `name` is an expression, see Todo comment for
details.
This is based on t
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
41ea02261224446dadb1b1561d70137699255518...2743af56220630f55a0c5bc0a7a13806c817aaad
lldb/
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo commented:
This looks great overall!
Could you split this PR into two? One with the refactoring and another one with
the new features? That would make reviewing easier
https://github.com/llvm/llvm-project/pull/81541
___
@@ -895,6 +906,32 @@ def request_setFunctionBreakpoints(self, names,
condition=None, hitCondition=Non
}
return self.send_recv(command_dict)
+def request_dataBreakpointInfo(self, variablesReference, name):
+args_dict = {"variablesReference": variabl
ZequanWu wrote:
> This looks great overall! Could you split this PR into two? One with the
> refactoring and another one with the new features? That would make reviewing
> easier
Yes, I already split it out: https://github.com/llvm/llvm-project/pull/80753 is
the refactor pr. I'll rebase this
walter-erquinigo wrote:
just ping me when this PR is rebased
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/81541
>From a2d28693da09a569b49bc39a4743e302b2479d87 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 13 Feb 2024 11:55:33 -0500
Subject: [PATCH] [lldb-dap] Add support for data breakpoint.
This implements functio
ZequanWu wrote:
> just ping me when this PR is rebased
Rebased.
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -895,6 +906,32 @@ def request_setFunctionBreakpoints(self, names,
condition=None, hitCondition=Non
}
return self.send_recv(command_dict)
+def request_dataBreakpointInfo(self, variablesReference, name):
+args_dict = {"variablesReference": variabl
11 matches
Mail list logo
