[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-07-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-07-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: CI failure is an unrelated BOLT test: ``` _bk;t=1719829907081Failed Tests (1): <...> _bk;t=1719829907081 BOLT :: X86/reader-stale-yaml-std.test <...> _bk;t=1719829907081 Failed : 1 (0.22%) ``` https://github.com/llvm/llvm-project/pull/85058 __

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-07-01 Thread Andrew Turner via lldb-commits
zxombie wrote: This looks good to me https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-07-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/85058 >From 6a013c6b46306c4d170efb1a6df2956c9dc61b30 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 4 Mar 2024 14:31:40 + Subject: [PATCH 1/2] [lldb][FreeBSD][AArch64] Enable register field detectio

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-07-01 Thread David Spickett via lldb-commits
@@ -18,9 +18,9 @@ namespace lldb_private { struct RegisterInfo; /// This class manages the storage and detection of register field information -/// for Arm64 Linux registers. The same register may have different fields on -/// different CPUs. This class abstracts out the field

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-07-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/85058 >From 33b750696a5958ae13420796e82fb9f5b2ea8fa9 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 4 Mar 2024 14:31:40 + Subject: [PATCH 1/2] [lldb][FreeBSD][AArch64] Enable register field detectio

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-28 Thread Alex Langford via lldb-commits
@@ -18,9 +18,9 @@ namespace lldb_private { struct RegisterInfo; /// This class manages the storage and detection of register field information -/// for Arm64 Linux registers. The same register may have different fields on -/// different CPUs. This class abstracts out the field

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-28 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-28 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Can't say I know a ton about FreeBSD but this looks fine to me. I left one suggestion but I would recommend getting a sign-off from one of the FreeBSD folks. https://github.com/llvm/llvm-project/pull/85058 ___

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/pull/95125 has now landed, so this PR is just the new changes. @zxombie we now check the HWCAP to see if the register exists at all, and only if it does, generate field information. What do you think to the changes as they are now? An

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/85058 >From 33b750696a5958ae13420796e82fb9f5b2ea8fa9 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 4 Mar 2024 14:31:40 + Subject: [PATCH] [lldb][FreeBSD][AArch64] Enable register field detection T

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-12 Thread David Spickett via lldb-commits
DavidSpickett wrote: Eventually we'll need to pass the OS type to the detector, but this is not needed now and quite easy to add when it is needed. https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-12 Thread David Spickett via lldb-commits
DavidSpickett wrote: Rebased so that commit #1 here is https://github.com/llvm/llvm-project/pull/95125. > It looks like svcr is for SME & mte_ctrl is for MTE. Neither of these are > currently supported in FreeBSD. When they are supported the appropriate HWCAP > flags (and ID_AA64* registers)

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-06-12 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/85058 >From 60086c78d9be91704158f45e19813217289757b7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 11 Jun 2024 13:41:18 + Subject: [PATCH 1/2] [lldb] Do not produce field information for registers

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-05-23 Thread David Spickett via lldb-commits
DavidSpickett wrote: I'm currently assuming that the process classes will check those HWCAPs and only add those registers to the register info if they exist. This code only patches registers that are already in the info, it doesn't add any new ones. That said, explicit is better than implicit,

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-05-22 Thread Andrew Turner via lldb-commits
zxombie wrote: It looks like `svcr` is for SME & `mte_ctrl` is for MTE. Neither of these are currently supported in FreeBSD. When they are supported the appropriate `HWCAP` flags (and `ID_AA64*` registers) will be set to tell userspace it can use them. https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-05-01 Thread Ed Maste via lldb-commits
emaste wrote: @zxombie fyi https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-04-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: @emaste ping! https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-04-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: @emaste the previous PRs have landed so this is just a single commit now, easier to review. https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-04-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/85058 >From a18b685eda074527abdd127456681b03ec2aed0f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 4 Mar 2024 14:31:40 + Subject: [PATCH] [lldb][FreeBSD][AArch64] Enable register field detection T

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-03-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This extends the existing register fields support from AArch64 Linux to AArch64 FreeBSD. So you will now see output like this: ``` (lldb) register read cpsr cpsr = 0x6200 = (N = 0, Z =

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-03-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: This is a stacked PR, the first two commits are https://github.com/llvm/llvm-project/pull/84147 and https://github.com/llvm/llvm-project/pull/85057. https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-03-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/85058 This extends the existing register fields support from AArch64 Linux to AArch64 FreeBSD. So you will now see output like this: ``` (lldb) register read cpsr cpsr = 0x6200 = (N = 0, Z = 1, C