https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/80753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
thanks!
https://github.com/llvm/llvm-project/pull/80753
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ZequanWu wrote:
I uploaded https://github.com/llvm/llvm-project/pull/81541 as reference for
reviewers to understand the motivation of this patch.
https://github.com/llvm/llvm-project/pull/80753
___
lldb-commits mailing list
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/80753
>From c4b767909a9ffc2a3015dc9021e4c265da0d877d Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Mon, 5 Feb 2024 17:26:48 -0500
Subject: [PATCH 1/3] [lldb-dap][NFC] Add Breakpoint struct to share common
logic.
@@ -0,0 +1,76 @@
+//===-- Breakpoint.cpp --*- C++
-*-===//
JDevlieghere wrote:
Nit: you don't need the `*- C++ -*` in source files as emacs can tell it's C++
by the extension, unlike in the header.
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/80753
>From c4b767909a9ffc2a3015dc9021e4c265da0d877d Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Mon, 5 Feb 2024 17:26:48 -0500
Subject: [PATCH 1/2] [lldb-dap][NFC] Add Breakpoint struct to share common
logic.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 41ea02261224446dadb1b1561d70137699255518
c4b767909a9ffc2a3015dc9021e4c265da0d877d --
