ZequanWu wrote:
>From logs, looks like setting breakpoint with size being 1 byte failed on arm,
>and works with size being 4 bytes.
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Prabhuk wrote:
We (Fuchsia clang toolchain team) are facing a LLDB test failure in our ARM64
Clang toolchain builders and I suspect this change is causing the failure.
Build link:
@@ -52,5 +52,6 @@ executable("lldb-dap") {
"RunInTerminal.cpp",
"SourceBreakpoint.cpp",
"lldb-dap.cpp",
+"Watchpoint.cpp"
nico wrote:
Please don't update gn build files if you don't use the gn build. There's a bot
that is able to do it most
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool
@@ -561,6 +561,46 @@ void EventThreadFunction() {
}
}
+lldb::SBValue FindVariable(uint64_t variablesReference, llvm::StringRef name) {
+ lldb::SBValue variable;
+ if (lldb::SBValueList *top_scope = GetTopLevelScope(variablesReference)) {
+bool
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool
@@ -561,6 +561,46 @@ void EventThreadFunction() {
}
}
+lldb::SBValue FindVariable(uint64_t variablesReference, llvm::StringRef name) {
+ lldb::SBValue variable;
+ if (lldb::SBValueList *top_scope = GetTopLevelScope(variablesReference)) {
+bool
@@ -2697,58 +2737,41 @@ void request_dataBreakpointInfo(const
llvm::json::Object ) {
GetUnsigned(arguments, "variablesReference", 0);
llvm::StringRef name = GetString(arguments, "name");
lldb::SBFrame frame = g_dap.GetLLDBFrame(*arguments);
- bool
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I think using @ is fine, but we can revisit it later if we see any issues.
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ZequanWu wrote:
I updated to add support for setting data breakpoint with expression. If
`variablesReference` is 0 or not provided, interpret `name` as `${number of
bytes}@${expression}` to set data breakpoint at the given expression because
the spec
@@ -2591,6 +2594,248 @@ void request_setFunctionBreakpoints(const
llvm::json::Object ) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "DataBreakpointInfoRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+//
@@ -2591,6 +2594,248 @@ void request_setFunctionBreakpoints(const
llvm::json::Object ) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "DataBreakpointInfoRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+//
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/81541
>From a2d28693da09a569b49bc39a4743e302b2479d87 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 13 Feb 2024 11:55:33 -0500
Subject: [PATCH 1/2] [lldb-dap] Add support for data breakpoint.
This implements
@@ -2591,6 +2594,248 @@ void request_setFunctionBreakpoints(const
llvm::json::Object ) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "DataBreakpointInfoRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+//
@@ -2591,6 +2594,248 @@ void request_setFunctionBreakpoints(const
llvm::json::Object ) {
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+// "DataBreakpointInfoRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" }, {
+// "type": "object",
+//
https://github.com/walter-erquinigo commented:
Amazing stuff! I've been wanting this for a while. I left some minor comments.
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/81541
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
26 matches
Mail list logo
