Re: [Lldb-commits] [lldb] 4b074b4 - [lldb] Fix UB in half2float and add some more tests.

2021-05-20 Thread Raphael “Teemperor” Isemann via lldb-commits
I think what you're looking for is llvm::bit_cast (in ADT/bit.h) :) But that code was written before that, so that's why it's still using unions > On 19 May 2021, at 23:27, Shafik Yaghmour wrote: > > *sigh*I wish we had std::bit_cast instead of using union based type punning, > we do have __bu

Re: [Lldb-commits] [lldb] 4b074b4 - [lldb] Fix UB in half2float and add some more tests.

2021-05-19 Thread Shafik Yaghmour via lldb-commits
*sigh*I wish we had std::bit_cast instead of using union based type punning, we do have __builtin_bit_cast but it is different enough that replacing it later on w/ std::bit_cast wouldn’t just be search/replace. > On May 19, 2021, at 12:37 PM, Raphael Isemann via lldb-commits > wrote: > > > A

[Lldb-commits] [lldb] 4b074b4 - [lldb] Fix UB in half2float and add some more tests.

2021-05-19 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-19T21:37:10+02:00 New Revision: 4b074b49be206306330076b9fa40632ef1960823 URL: https://github.com/llvm/llvm-project/commit/4b074b49be206306330076b9fa40632ef1960823 DIFF: https://github.com/llvm/llvm-project/commit/4b074b49be206306330076b9fa40632ef1960823.dif