Re: [Lldb-commits] [lldb] 92b475f - [lldb] silence -Wsometimes-uninitialized warnings

2021-09-28 Thread Michał Górny via lldb-commits
On Tue, 2021-09-28 at 09:37 +0200, Krasimir Georgiev wrote: > Thank you David. I just initialized these variables as suggested by > the warnings, without considering this case. > Michał, could you please double check this case? Hmm, you're probably right. The diagnostic should probably print

Re: [Lldb-commits] [lldb] 92b475f - [lldb] silence -Wsometimes-uninitialized warnings

2021-09-28 Thread Krasimir Georgiev via lldb-commits
Thank you David. I just initialized these variables as suggested by the warnings, without considering this case. Michał, could you please double check this case? On Mon, Sep 27, 2021 at 9:09 PM David Blaikie wrote: > Maybe this isn't the right fix - msbit and lsbit probably shouldn't be >

Re: [Lldb-commits] [lldb] 92b475f - [lldb] silence -Wsometimes-uninitialized warnings

2021-09-27 Thread David Blaikie via lldb-commits
Maybe this isn't the right fix - msbit and lsbit probably shouldn't be printed if to_integer returns false in the diagnostic on line 195. If that diagnostic didn't use the variables, then I don't think this'd warn? On Mon, Sep 27, 2021 at 12:38 AM Krasimir Georgiev via lldb-commits <

[Lldb-commits] [lldb] 92b475f - [lldb] silence -Wsometimes-uninitialized warnings

2021-09-27 Thread Krasimir Georgiev via lldb-commits
Author: Krasimir Georgiev Date: 2021-09-27T09:35:58+02:00 New Revision: 92b475f0b079e125c588b121dc50116ea5d6d9f2 URL: https://github.com/llvm/llvm-project/commit/92b475f0b079e125c588b121dc50116ea5d6d9f2 DIFF: