clayborg wrote:
> (aside: isn't the SBAPI meant to be the thing to use if you want to script
> stuff, rather than having formatted output/scraping that? - but sounds like
> the output has converged on a table rather than JSON anyway? So maybe a moot
> point)
The reason we use StructuredData
https://github.com/zhyty closed https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From fe1f2874d91b6583759f43ba5a0ed28b44275ab6 Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH 1/3] Add `target modules dump separate-debug-info`
Summary:
Add a new
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From 9a52ac5193af2a8ddca2a5d922684935b043d0ef Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH 1/2] Add `target modules dump separate-debug-info`
Summary:
Add a new
clayborg wrote:
> I am not a big fan of having a specialized name `separate-debug-info` to dump
> external debug info. Ideally, I would like a single/centralized command for
> end users to see/check symbols/debug info status for a target including all
> possible situations.
>
> How about we
@@ -1462,6 +1464,87 @@ static bool DumpModuleSymbolFile(Stream , Module
*module) {
return false;
}
+static bool GetSeparateDebugInfoList(StructuredData::Array ,
+ Module *module) {
+ if (module) {
+if (SymbolFile *symbol_file =
@@ -1462,6 +1464,87 @@ static bool DumpModuleSymbolFile(Stream , Module
*module) {
return false;
}
+static bool GetSeparateDebugInfoList(StructuredData::Array ,
+ Module *module) {
+ if (module) {
+if (SymbolFile *symbol_file =
jeffreytan81 wrote:
I am not a big fan of having a specialized name `separate-debug-info` to dump
external debug info. Ideally, I would like a single/centralized command for end
users to see check symbols/debug info status for a target including all
possible situations.
How about we rename
@@ -1462,6 +1464,87 @@ static bool DumpModuleSymbolFile(Stream , Module
*module) {
return false;
}
+static bool GetSeparateDebugInfoList(StructuredData::Array ,
+ Module *module) {
+ if (module) {
+if (SymbolFile *symbol_file =
dwblaikie wrote:
> N_SO is the stab moniker for a source file, and N_OSO is the object file
> associated with that source file (N_SO was in Sun's implementation, we made
> up N_OSO). Most nm''s leave off the N_ when they print stabs, so then this
> became just OSO...
> We don't do DWO on
jimingham wrote:
N_SO is the stab moniker for a source file, and N_OSO is the object file
associated with that source file (N_SO was in Sun's implementation, we made up
N_OSO). Most nm''s leave off the N_ when they print stabs, so then this became
just OSO...
We don't do DWO on Darwin, and
dwblaikie wrote:
(aside: isn't the SBAPI meant to be the thing to use if you want to script
stuff, rather than having formatted output/scraping that? - but sounds like the
output has converged on a table rather than JSON anyway? So maybe a moot point)
Re: errors, OSO (what does that stand for
https://github.com/zhyty edited https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From 9a52ac5193af2a8ddca2a5d922684935b043d0ef Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH 1/2] Add `target modules dump separate-debug-info`
Summary:
Add a new
jimingham wrote:
People can either look at the detailed JSON output or just go look at that path
to figure out what went wrong, so just S & E would be fine for now.
Jim
> On Sep 15, 2023, at 11:18 AM, Tom Yang ***@***.***> wrote:
>
>
> I think it would be easier to read the output if you
zhyty wrote:
> > > I think it would be easier to read the output if you made a separate
> > > column for "error". If you imagine a listing where there are 100 OSO's of
> > > which 10 are missing, the paths are going to jump over because of the
> > > "error: ..." at the beginning of those
jimingham wrote:
> > I think it would be easier to read the output if you made a separate column
> > for "error". If you imagine a listing where there are 100 OSO's of which 10
> > are missing, the paths are going to jump over because of the "error: ..."
> > at the beginning of those lines
clayborg wrote:
> I think it would be easier to read the output if you made a separate column
> for "error". If you imagine a listing where there are 100 OSO's of which 10
> are missing, the paths are going to jump over because of the "error: ..." at
> the beginning of those lines making it
https://github.com/jimingham commented:
I think it would be easier to read the output if you made a separate column for
"error". If you imagine a listing where there are 100 OSO's of which 10 are
missing, the paths are going to jump over because of the "error: ..." at the
beginning of those
zhyty wrote:
Added tests for the human-readable/table format.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From 9a52ac5193af2a8ddca2a5d922684935b043d0ef Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From 5bf6c4a90bf578af56fb0da30586086fd777bd55 Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new
@@ -11,6 +11,7 @@
#include "DIERef.h"
#include "lldb/Symbol/SymbolFile.h"
+#include "lldb/Utility/ConstString.h"
clayborg wrote:
Remove this now that we aren't returning a std::optional
https://github.com/llvm/llvm-project/pull/66035
https://github.com/clayborg requested changes to this pull request.
Just need tests for the non --json output for OSO and DWO. If you can also
attach the output of the 4 cases (OSO no errors, OSO with errors, DWO no errors
and DWO with errors), that might help people see what this output looks
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zhyty wrote:
Addressed @clayborg's comments: removed trailing whitespaces, simplify the
`SymbolFile` functions into one.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2035,8 +2118,8 @@ class CommandObjectTargetModulesDumpSymtab
result.GetOutputStream().EOL();
result.GetOutputStream().EOL();
}
- if (INTERRUPT_REQUESTED(GetDebugger(),
zhyty wrote:
Done. Turns
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From 2bb9a2a245d214bf4201d28037f498da5a94c78f Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new
@@ -2035,8 +2118,8 @@ class CommandObjectTargetModulesDumpSymtab
result.GetOutputStream().EOL();
result.GetOutputStream().EOL();
}
- if (INTERRUPT_REQUESTED(GetDebugger(),
clayborg wrote:
It would be
@@ -162,6 +163,21 @@ void SymbolFile::AssertModuleLock() {
SymbolFile::RegisterInfoResolver::~RegisterInfoResolver() = default;
+bool SymbolFile::ListSeparateDebugInfoFiles(StructuredData::Dictionary ) {
+ StructuredData::Array array;
+ std::optional debug_info_type =
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -459,6 +470,14 @@ class SymbolFile : public PluginInterface {
virtual void GetCompileOptions(
std::unordered_map ) {}
+ /// If separate debug info files are supported and this function succeeded,
+ /// return some string representing the type of debug info. E.g.
zhyty wrote:
Updated to show a more human-readable format @jimingham.
Also addressed comments by @DavidSpickett.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/zhyty edited https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From 94b834f747fe66a50288e23fec2d00918f4fc8ef Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From d0538bc86ec02819ed9a24d06a2e7fc355447f4b Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new
@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable
CommandOptions m_options;
};
+#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles
+
+// Image debug dwo dumping command
+
+class CommandObjectTargetModulesDumpSeparateDebugInfoFiles
+:
Not necessary for this review, but it might be nice to have a --missing or
similar flag to this command that filters the output to only the ones that are
missing. Seems like a lot of the time I would want to use this command it
would be to find missing dwo or oso files.
Jim
> On Sep 11,
@@ -2005,9 +2021,10 @@ class CommandObjectTargetModulesDumpSymtab
result.GetOutputStream().EOL();
result.GetOutputStream().EOL();
}
- if (INTERRUPT_REQUESTED(GetDebugger(),
+ if (INTERRUPT_REQUESTED(GetDebugger(),
jimingham wrote:
> > I don't think the lldb command line dumps raw JSON anywhere as a command
> > result. Can we make something a little more human readable?
>
> It was my idea to make this JSON. The problem is each debug info (.dwo and
> DWARF in .o files for Mac) has very different fields
https://github.com/adrian-prantl review_requested
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
FYI I committed https://reviews.llvm.org/D157609 recently. Looks like your test
cases are pretty straightforward but just in case you are confused why lldb
manages to find a file when it didn't previously.
https://github.com/llvm/llvm-project/pull/66035
@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable
CommandOptions m_options;
};
+#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles
+
+// Image debug dwo dumping command
+
+class CommandObjectTargetModulesDumpSeparateDebugInfoFiles
+:
@@ -4214,6 +4216,62 @@ void SymbolFileDWARF::DumpClangAST(Stream ) {
clang->Dump(s.AsRawOstream());
}
+bool SymbolFileDWARF::GetSeparateDebugInfoFiles(StructuredData::Array ) {
+ DWARFDebugInfo = DebugInfo();
+ const size_t num_cus = info.GetNumUnits();
+ for (size_t
@@ -282,6 +283,10 @@ class SymbolFileDWARF : public
lldb_private::SymbolFileCommon {
void DumpClangAST(lldb_private::Stream ) override;
+ /// Retrieve the external dwo files.
DavidSpickett wrote:
"external dwo file details." ?
@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable
CommandOptions m_options;
};
+#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles
+
+// Image debug dwo dumping command
+
+class CommandObjectTargetModulesDumpSeparateDebugInfoFiles
+:
@@ -2462,6 +2483,93 @@ class CommandObjectTargetModulesDumpLineTable
CommandOptions m_options;
};
+#pragma mark CommandObjectTargetModulesDumpSeparateDebugInfoFiles
+
+// Image debug dwo dumping command
+
+class CommandObjectTargetModulesDumpSeparateDebugInfoFiles
+:
@@ -2005,9 +2021,10 @@ class CommandObjectTargetModulesDumpSymtab
result.GetOutputStream().EOL();
result.GetOutputStream().EOL();
}
- if (INTERRUPT_REQUESTED(GetDebugger(),
+ if (INTERRUPT_REQUESTED(GetDebugger(),
clayborg wrote:
We also want to show the .dwo error or OSO error strings that explain why the
file wasn't loaded as we see when we do "frame variable" and the OSO or DWO are
missing.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits
clayborg wrote:
> I don't think the lldb command line dumps raw JSON anywhere as a command
> result. Can we make something a little more human readable?
It was my idea to make this JSON. The problem is each debug info (.dwo and
DWARF in .o files for Mac) has very different fields and pretty
jimingham wrote:
BTW, the idea seems useful to me, but particularly if you're doing OSO you can
get a whole lot of these so a space efficient presentation where you can scan
the names easily, etc, will be important as well.
https://github.com/llvm/llvm-project/pull/66035
jimingham wrote:
I don't think the lldb command line dumps raw JSON anywhere as a command
result. Can we make something a little more human readable?
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From 0f4cf3648bd1a8d6e9114965e6eb6cdbc7ed01dd Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Summary:
Add a new command
```
target modules dump separate-debug-info [ ...]
```
or
```
image dump separate-debug-info [ ...]
```
(since `image` is an alias for `target modules`).
This lists the separate debug info files and their current
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty created
https://github.com/llvm/llvm-project/pull/66035:
Summary:
Add a new command
```
target modules dump separate-debug-info [ ...]
```
or
```
image dump separate-debug-info [ ...]
```
(since `image` is an alias for `target modules`).
This lists the separate debug
https://github.com/zhyty review_requested
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty review_requested
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty review_requested
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
70 matches
Mail list logo
