[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-16 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @usama54321 I had to revert this because it broke both the arm64 and x86 bots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/1078/ https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-15 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 closed https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-15 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From 18757485878c4455032883ebfeb13483dc3ab469 Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-15 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
usama54321 wrote: > Will this test primarily be run at-desk? Or will it be a part of existing CI? > I know we have discussed this previously, I just want to confirm as I'm > putting together documentation for this kind of testing for libsanitizers. > I'd love to make note somewhere where we ex

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
usama54321 wrote: Changed the no_libsanitizers function to use the LLDB image list command https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From 59ee9026bc0d35bcde83ff45aacb272bb39902b0 Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. `dyld_shared_cache_util` doesn't come preinstalled on macOS (you can build it yourself locally from source) so I think we should use lldb to check if the library is loaded. https://github.com/llvm/llvm-project/pull/88349 _

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread via lldb-commits
https://github.com/thetruestblue approved this pull request. https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread via lldb-commits
https://github.com/thetruestblue deleted https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread via lldb-commits
@@ -26,6 +33,68 @@ def setUp(self): self.line_free = line_number("main.c", "// free line") self.line_breakpoint = line_number("main.c", "// break line") +# Test line numbers: rdar://126237493 +def libsanitizer_tests(self): +target = self.createT

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread via lldb-commits
thetruestblue wrote: Will this test primarily be run at-desk? Or will it be a part of existing CI? I know we have discussed this previously, I just want to confirm as I'm putting together documentation for this kind of testing for libsanitizers https://github.com/llvm/llvm-project/pull/88349 _

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
usama54321 wrote: Added a util function to skip tests if libsanitizers is not present in the shared cache https://github.com/llvm/llvm-project/pull/88349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From b25a5a0b5beb249c8a646cbfc02b865ca91ab861 Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread via lldb-commits
https://github.com/jimingham requested changes to this pull request. Please do move the stop reason test up before all the other tests, since it conditions them. Other than that, this LGTM. https://github.com/llvm/llvm-project/pull/88349 ___ lldb-

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
@@ -26,6 +31,67 @@ def setUp(self): self.line_free = line_number("main.c", "// free line") self.line_breakpoint = line_number("main.c", "// break line") +# Test line numbers: rdar://126237493 +def libsanitizer_tests(self): +target = self.createT

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From c336a2ad53121bedd52a80169d11e5617c7058ed Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread via lldb-commits
@@ -26,6 +31,67 @@ def setUp(self): self.line_free = line_number("main.c", "// free line") self.line_breakpoint = line_number("main.c", "// break line") +# Test line numbers: rdar://126237493 +def libsanitizer_tests(self): +target = self.createT

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread via lldb-commits
@@ -26,6 +31,67 @@ def setUp(self): self.line_free = line_number("main.c", "// free line") self.line_breakpoint = line_number("main.c", "// break line") +# Test line numbers: rdar://126237493 +def libsanitizer_tests(self): +target = self.createT

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-11 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From 3d31b403aad13f8eb8a9377390f05a310bfa0999 Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From de4ed3289ecb52b4971f6abe942c0a3af9e6425a Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/88349 >From a1ef63cd8f5bb927fc58827996b22c1f4dba15bb Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subject: [PATCH] [LLDB] Add asan tests for libsanitizers. This patch tests LLDB integr

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 026165fad70420d85defb5fc9109c138250058ee...4cee76dff9b474a6a6bd278ea69cde6c3be924ad lldb/

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread Usama Hameed via lldb-commits
usama54321 wrote: I reused the test in TestReportData because the output should match exactly with current ASan. For TestMemoryHistory, libsanitizers currently only supports the memory history plugin for addresses for which a report has been generated, so I wrote a test separately. https://gi

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Usama Hameed (usama54321) Changes This patch tests LLDB integration with libsanitizers for ASan. rdar://111856681 --- Full diff: https://github.com/llvm/llvm-project/pull/88349.diff 3 Files Affected: - (modified) lldb/test/API/functiona

[Lldb-commits] [lldb] Add asan tests for libsanitizers. (PR #88349)

2024-04-10 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 created https://github.com/llvm/llvm-project/pull/88349 This patch tests LLDB integration with libsanitizers for ASan. rdar://111856681 >From 4cee76dff9b474a6a6bd278ea69cde6c3be924ad Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 10 Apr 2024 21:07:11 -0700 Subje