https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/83099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
I'm happy if Jason is happy!
https://github.com/llvm/llvm-project/pull/83099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/jasonmolenda approved this pull request.
LGTM, let's land this patch. I will extend the stub version packet with
additional fields (Jonas points out that other stubs implement this packet
already as-is) and update this once that PR is approved and merged. But we
don't
jasonmolenda wrote:
I'm not fishing for Adrian to dig in to that, I'm happy to make the change.
but I'm curious what @JDevlieghere and @adrian-prantl think, if it's worth
changing this packet. It's not used anywhere yet, so overhauling it now
before/shortly after we actually start using it,
jasonmolenda wrote:
I'm a little split because the current packet is not super useful as it's
constructed today - I'd really like to see a domain or vendor along with a
version number And instead of a simple number, maybe a major/minor version
number and/or a version string? I'm also fine
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/83099
>From 6f74b0bd4cfb3aacf42b9b65a019dba425c7d18e Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 26 Feb 2024 16:50:27 -0800
Subject: [PATCH] Make the workaround for older debugserver versions more
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/83099
>From f26292e7db372380fab4fd83f9df79a5b8929772 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 26 Feb 2024 18:43:57 -0800
Subject: [PATCH] Aim debugserver workaround more precisely.
---
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/83099.diff
2 Files Affected:
- (modified)
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (+14-1)
- (modified)
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/83099
None
>From 1b020afcb50cd6059bbe2ab26779ed6d3e7c2f7a Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 26 Feb 2024 18:43:57 -0800
Subject: [PATCH] Aim debugserver workaround more precisely.
---
