[Lldb-commits] [lldb] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-04 Thread via lldb-commits
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?=, Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?= Message-ID: In-Reply-To: https://github.com/whisperity approved this pull request. > TIL there is no way to resign a review here like there was on Phab... https://github.com/llvm/llvm-project/pull/66487 __

[Lldb-commits] [lldb] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-04 Thread via lldb-commits
Botond =?utf-8?q?István_Hprváth?=, Botond =?utf-8?q?István_Hprváth?Message-ID: In-Reply-To: https://github.com/whisperity commented: LGTM with previous discussion. I will do the commit... On the UI... :slightly_smiling_face: https://github.com/llvm/llvm-project/pull/66487

[Lldb-commits] [lldb] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-04 Thread via lldb-commits
Botond =?utf-8?q?István_Hprváth?=, Botond =?utf-8?q?István_Hprváth?Message-ID: In-Reply-To: https://github.com/whisperity edited https://github.com/llvm/llvm-project/pull/66487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-04 Thread Botond István Hprváth via lldb-commits
@@ -85,3 +85,38 @@ int main() { } + +namespace deduceTemplatedConstructor{ HoBoIs wrote: Done https://github.com/llvm/llvm-project/pull/66487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-04 Thread via lldb-commits
Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?= Message-ID: In-Reply-To: https://github.com/whisperity requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-04 Thread Botond István Hprváth via lldb-commits
HoBoIs wrote: @erichkeane @shafik I don't have write access. Could you merge if there is nothing to be done? https://github.com/llvm/llvm-project/pull/66487 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-04 Thread Botond István Hprváth via lldb-commits
https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/5] Choose the correct deduction guide If there are two guides, one of th

[Lldb-commits] [lldb] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-04 Thread Botond István Hprváth via lldb-commits
https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/4] Choose the correct deduction guide If there are two guides, one of th