antmox wrote:
@clayborg yes sure I will test this on the same machine
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> [antmox](/antmox)
https://github.com/llvm/llvm-project/pull/72315
A new PR to fix this issue. Is there any way you can test this to see if this
works?
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
ll
clayborg wrote:
> [core_dmps.tar.gz](https://github.com/llvm/llvm-project/files/13355872/core_dmps.tar.gz)
> here is an archive with the 2 core.dmp files
It does indeed seem like my new core file creation code is being triggered on
windows. I am working on a fix that adds ARM64 support to the
antmox wrote:
[core_dmps.tar.gz](https://github.com/llvm/llvm-project/files/13355872/core_dmps.tar.gz)
here is an archive with the 2 core.dmp files
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
clayborg wrote:
> @clayborg I will try to reproduce on the buildbot windows machine. build
> ongoing
If you end up being able to reproduce, if you can send the minidump file that
was produced I should be able to look at it to make sure it was not produced by
the core file saver. But if this i
antmox wrote:
@clayborg
I will try to reproduce on the buildbot windows machine. build ongoing
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
clayborg wrote:
Does anyone have access to a native windows arm64 build of LLDB that could help
look at this?
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
clayborg wrote:
> Hello @clayborg ! Looks like this patch broke lldb-aarch64-windows bot:
> https://lab.llvm.org/buildbot/#/builders/219/builds/6868 Could you please
> look at this ?
@antmox
I looked at this and I didn't touch anything related to native windows core
file saving. If this is
antmox wrote:
Hello @clayborg ! Looks like this patch broke lldb-aarch64-windows bot:
https://lab.llvm.org/buildbot/#/builders/219/builds/6868
Could you please look at this ?
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing li
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/71772
>From f1bd931ff434012888b0b87a75daaf6ba99102c0 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 8 Nov 2023 21:14:49 -0800
Subject: [PATCH 1/3] Centralize the code that figures out which memory ranges
to s
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/71772
>From feea395f4ef165dfc057dfdc0649c6948895eeb3 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 8 Nov 2023 21:14:49 -0800
Subject: [PATCH 1/3] Centralize the code that figures out which memory ranges
to s
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
d0da3d8393939790bb1a6b3b5a36daeeef000c9b..50e81f16a6c09d19af53e64818d3b67ebb8dbfd0
lldb/
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/71772
>From feea395f4ef165dfc057dfdc0649c6948895eeb3 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 8 Nov 2023 21:14:49 -0800
Subject: [PATCH 1/2] Centralize the code that figures out which memory ranges
to s
jasonmolenda wrote:
> @jasonmolenda I was wondering if we should modify
> `GetCoreFileSaveRangesDirtyOnly(...)` to try and add all dirty pages and see
> if any regions have the dirty page info, but if no memory region infos have
> the dirty pages information, then fall back to adding all memor
bulbazord wrote:
> I addressed most of the feedback. Alex let me know if you still really want
> llvm::Error and llvm::Expected to be used as I can add that if you think it
> is required. I also ran clang format.
I think your answers make sense to me. I don't think you need to add them here
s
clayborg wrote:
@bulbazord let me know if you require any changes after reading my inline
comments.
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
clayborg wrote:
@jasonmolenda I was wondering if we should modify
`GetCoreFileSaveRangesDirtyOnly(...)` to try and add all dirty pages and see if
any regions have the dirty page info, but if no memory region infos have the
dirty pages information, then fall back to adding all memory regions wi
clayborg wrote:
I addressed most of the feedback. Alex let me know if you still really want
llvm::Error and llvm::Expected to be used as I can add that if you think it is
required. I also ran clang format.
https://github.com/llvm/llvm-project/pull/71772
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/71772
>From feea395f4ef165dfc057dfdc0649c6948895eeb3 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Wed, 8 Nov 2023 21:14:49 -0800
Subject: [PATCH] Centralize the code that figures out which memory ranges to
save
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -704,7 +705,37 @@ class Process : public
std::enable_shared_from_this,
/// is not supported by the plugin, error otherwise.
virtual llvm::Expected SaveCore(llvm::StringRef outfile);
+ struct CoreFileMemoryRange {
+llvm::AddressRange range; /// The address rang
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -704,7 +705,37 @@ class Process : public
std::enable_shared_from_this,
/// is not supported by the plugin, error otherwise.
virtual llvm::Expected SaveCore(llvm::StringRef outfile);
+ struct CoreFileMemoryRange {
+llvm::AddressRange range; /// The address rang
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/71772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -6252,3 +6243,188 @@ Status Process::WriteMemoryTags(lldb::addr_t addr,
size_t len,
return DoWriteMemoryTags(addr, len, tag_manager->GetAllocationTagType(),
*packed_tags);
}
+
+// Create a CoreFileMemoryRange from a MemoryRegionInfo
+static Proc
@@ -704,7 +705,37 @@ class Process : public
std::enable_shared_from_this,
/// is not supported by the plugin, error otherwise.
virtual llvm::Expected SaveCore(llvm::StringRef outfile);
+ struct CoreFileMemoryRange {
+llvm::AddressRange range; /// The address rang
https://github.com/jasonmolenda approved this pull request.
A couple of small nits but looks good to me. I do have a little concern about
pulling in `llvm/ADT/AddressRanges.h` in Process.h to get llvm::AddressRange
when we have an lldb_private::AddressRange, which is used in a number of places
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 21861991e760e7e845dc1be5b804c950543d699a
9ff1e92175f90613de6f07dfb4821b8fc0226939 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Greg Clayton (clayborg)
Changes
Prior to this patch, each core file plugin (ObjectFileMachO.cpp and
ObjectFileMinindump.cpp) would calculate the address ranges to save in
different ways. This patch adds a new function to Process.h/.cpp:
`
https://github.com/clayborg created
https://github.com/llvm/llvm-project/pull/71772
Prior to this patch, each core file plugin (ObjectFileMachO.cpp and
ObjectFileMinindump.cpp) would calculate the address ranges to save in
different ways. This patch adds a new function to Process.h/.cpp:
```
45 matches
Mail list logo
