[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
https://github.com/hjyamauchi created https://github.com/llvm/llvm-project/pull/84362 MSVC fails when there is ambiguity (multiple options) around implicit type conversion operators. Make ConstString's conversion operator to string_view explicit to avoid ambiguity with one to StringRef and re

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Hiroshi Yamauchi (hjyamauchi) Changes MSVC fails when there is ambiguity (multiple options) around implicit type conversion operators. Make ConstString's conversion operator to string_view explicit to avoid ambiguity with one to StringRef

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
hjyamauchi wrote: This demonstrates the Clang vs MSVC behavior difference: https://godbolt.org/z/GvsdEM5r7 https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
hjyamauchi wrote: CC @compnerd https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
hjyamauchi wrote: CC @compnerd https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Saleem Abdulrasool via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Alex Langford via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Hiroshi Yamauchi via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Saleem Abdulrasool via lldb-commits
@@ -168,8 +168,8 @@ class ConstString { // Implicitly convert \class ConstString instances to \class StringRef. operator llvm::StringRef() const { return GetStringRef(); } - // Implicitly convert \class ConstString instances to \class std::string_view. - operator std::s

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-07 Thread Saleem Abdulrasool via lldb-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix MSVC build issues (PR #84362)

2024-03-12 Thread Hiroshi Yamauchi via lldb-commits
https://github.com/hjyamauchi closed https://github.com/llvm/llvm-project/pull/84362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits